Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 4 - Option to disable specific activity types from being shown in the activity list #13

Merged
merged 16 commits into from
May 9, 2021
Merged

Issue 4 - Option to disable specific activity types from being shown in the activity list #13

merged 16 commits into from
May 9, 2021

Conversation

PuneetGopinath
Copy link
Member

@PuneetGopinath PuneetGopinath commented May 9, 2021 •
edited
Loading

Thank you for contributing! Please check the following things before submiting your PR:

Required:

If necessary:

  • I have updated the ChangeLog with the changes I have made.
  • I have updated the README and documentation.

Closes #4

Closes #4

Note: we will close your PR without comment if you do not check the required boxes above and provide ALL requested information.

@PuneetGopinath PuneetGopinath added Type: enhancement New feature or request minor Will be added to next minor release labels May 9, 2021
@PuneetGopinath PuneetGopinath requested a review from abhijoshi2k May 9, 2021 08:11
@PuneetGopinath PuneetGopinath marked this pull request as ready for review May 9, 2021 08:11
@PuneetGopinath
Copy link
Member Author

@abhijoshi2k Plz review

abhijoshi2k
abhijoshi2k requested changes May 9, 2021
View reviewed changes
Copy link
Member

@abhijoshi2k abhijoshi2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put questions in description. Change those to descriptive statements.
Questions do not look good I feel.

@PuneetGopinath
Copy link
Member Author

Don't put questions in description. Change those to descriptive statements.
Questions do not look good I feel.

Oh, will change

@PuneetGopinath
Copy link
Member Author

PuneetGopinath commented May 9, 2021 •
edited
Loading

I am getting error Error: Invalid status code: 1 --
See https://github.com/PuneetGopinath/PuneetGopinath/runs/2538106114?check_suite_focus=true

@abhijoshi2k
Copy link
Member

I think you have put conditions on wrong region.
They should be put when filter function is used.

@PuneetGopinath
Copy link
Member Author

I think you have put conditions on wrong region.
They should be put when filter function is used.

Ok, will check

@PuneetGopinath
Copy link
Member Author

Can you help me

@PuneetGopinath PuneetGopinath changed the title Issue 4 Issue 4 - Option to disable specific activity types from being shown in the activity list May 9, 2021
@abhijoshi2k
Copy link
Member

Can you help me

Yeah. You want me to take over this branch?

@abhijoshi2k
Copy link
Member

I think your current code should also work

@PuneetGopinath PuneetGopinath requested a review from Andre601 as a code owner May 9, 2021 09:20
@abhijoshi2k
Copy link
Member

I found the issue bro.
Issue was that the values are not boolean. They are considered string.

@abhijoshi2k abhijoshi2k removed the request for review from Andre601 May 9, 2021 09:39
@abhijoshi2k abhijoshi2k merged commit 6eca7fd into main May 9, 2021
@abhijoshi2k abhijoshi2k deleted the issue-4 branch May 9, 2021 09:44
@abhijoshi2k abhijoshi2k restored the issue-4 branch May 9, 2021 09:45
@PuneetGopinath
Copy link
Member Author

I found the issue bro.
Issue was that the values are not boolean. They are considered string.

Oh, Thanks

@PuneetGopinath PuneetGopinath deleted the issue-4 branch May 9, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhijoshi2k abhijoshi2k abhijoshi2k approved these changes

Assignees
No one assigned
Labels
minor Will be added to next minor release Type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Option to disable specific activity types from being shown in the activity list
2 participants
@PuneetGopinath @abhijoshi2k