Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added URL_FORMAT parameter #15

Merged
merged 6 commits into from
May 9, 2021
Merged

Added URL_FORMAT parameter #15

merged 6 commits into from
May 9, 2021

Conversation

abhijoshi2k
Copy link
Member

Thank you for contributing! Please check the following things before submiting your PR:

Required:

If necessary:

  • I have updated the README and documentation.
  • I have updated the ChangeLog with the changes I have made.

Added parameter to customize output of events.


Note: we will close your PR without comment if you do not check the required boxes above and provide ALL requested information.

@abhijoshi2k
Copy link
Member Author

@Andre601 @PuneetGopinath Can you please test and review?

@PuneetGopinath
Copy link
Member

@Andre601 @PuneetGopinath Can you please test and review?

Yes, plz wait

@Andre601
Copy link
Member

Andre601 commented May 9, 2021

Doesn't look like it works?

image
image

@abhijoshi2k
Copy link
Member Author

Doesn't look like it works?

image
image

I forgot to run build. Please try now

@Andre601
Copy link
Member

Andre601 commented May 9, 2021

Seems to do the job.
image

@PuneetGopinath
Copy link
Member

Seems to do the job.
image

Yes, it works after running build

@PuneetGopinath PuneetGopinath marked this pull request as ready for review May 9, 2021 13:32
@abhijoshi2k
Copy link
Member Author

abhijoshi2k commented May 9, 2021

@PuneetGopinath can you update changelog on same branch.
And
@Andre601 can you update readme for the same on this branch?
Then we will merge this pr and release

@PuneetGopinath
Copy link
Member

@PuneetGopinath can you update changelog on same branch.
And
@Andre601 can you update readme for the same on this branch?
Then we will merge this pr and release

No need to update changelog, as this pr updates #11

@Andre601
Copy link
Member

Andre601 commented May 9, 2021

One thing tho... URL_FORMAT sounds misleading as all this does is essentially changing the text in the embedded link.
So why not call it URL_TEXT instead?

@abhijoshi2k
Copy link
Member Author

One thing tho... URL_FORMAT sounds misleading as all this does is essentially changing the text in the embedded link.
So why not call it URL_TEXT instead?

Sounds right. I'll make the changes and push.

@abhijoshi2k
Copy link
Member Author

@PuneetGopinath can you update changelog on same branch.
And
@Andre601 can you update readme for the same on this branch?
Then we will merge this pr and release

No need to update changelog, as this pr updates #11

Okay

@abhijoshi2k
Copy link
Member Author

@Andre601 we will merge after you update readme.
Do it on this branch itself.

@abhijoshi2k
Copy link
Member Author

This looks good @Andre601 .
I think this is ready to be merged. What do you think? @PuneetGopinath

@PuneetGopinath
Copy link
Member

This looks good @Andre601 .
I think this is ready to be merged. What do you think? @PuneetGopinath

Looks good

@abhijoshi2k
Copy link
Member Author

This looks good @Andre601 .
I think this is ready to be merged. What do you think? @PuneetGopinath

Looks good

Alright. I'll merge

@abhijoshi2k abhijoshi2k merged commit 664a31c into main May 9, 2021
@abhijoshi2k abhijoshi2k deleted the url-feature branch May 9, 2021 14:19
@abhijoshi2k
Copy link
Member Author

@PuneetGopinath @Andre601 Should I release this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants