Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to display date and time of last update #40

Merged
merged 28 commits into from
May 17, 2021

Conversation

abhijoshi2k
Copy link
Member

@abhijoshi2k abhijoshi2k commented May 16, 2021

Thank you for contributing! Please check the following things before submiting your PR:

Required:

If necessary:

  • I have updated the README and documentation.
  • I have updated the ChangeLog with the changes I have made.

Description

Added support for Date of update
Markdown file comments changed as follows:
<!--START_SECTION:activity--> changes to <!--RECENT_ACTIVITY:start-->
<!--END_SECTION:activity--> changes to <!--RECENT_ACTIVITY:start-->

For adding Date, add this to your markdown file:
<!--RECENT_ACTIVITY:last_update-->

For adding timezone and date format, add the following parameters to .yml file:
TIMEZONE_OFFSET

    description: "Timezone in which time is to be displayed"
    default: "0"
    required: false

DATE_STRING

    description: "String to be printed while printing updation date"
    default: "Last Updated: {DATE}"
    required: false

DATE_FORMAT

    description: "Format of how last updation time to be printed"
    default: "dddd, mmmm dS, yyyy, h:MM:ss TT"
    required: false

For date formats, refer : https://www.npmjs.com/package/dateformat

Closes #


Note: we will close your PR without comment if you do not check the required boxes above and provide ALL requested information.

@github-actions github-actions bot added the Updates: documentation Improvements or additions to documentation label May 17, 2021
@PuneetGopinath PuneetGopinath added minor Will be added to next minor release Status: In progress This pr or issue is in progress Type: enhancement New feature or request and removed Updates: documentation Improvements or additions to documentation labels May 17, 2021
@github-actions github-actions bot added the Updates: documentation Improvements or additions to documentation label May 17, 2021
@abhijoshi2k abhijoshi2k removed the Updates: documentation Improvements or additions to documentation label May 17, 2021
@abhijoshi2k abhijoshi2k marked this pull request as ready for review May 17, 2021 08:51
@abhijoshi2k abhijoshi2k requested a review from Andre601 as a code owner May 17, 2021 08:51
@PuneetGopinath
Copy link
Member

It's just the offset from GMT which is UTC, so yes. I for example had +2:00 set on the above date

Thanks, do you think #39 is ready for review

@Andre601
Copy link
Member

Once this is merged will I add some info to the Release to inform about breaking changes.

@abhijoshi2k
Copy link
Member Author

0 will set the timezone to UTC right

Yes

@abhijoshi2k
Copy link
Member Author

@abhijoshi2k You have to review #39 before this pr can be merged

I shall do it. There are some changes I have to make here.
Will fix 1 bug and then review #39

@github-actions github-actions bot added the Updates: documentation Improvements or additions to documentation label May 17, 2021
@abhijoshi2k abhijoshi2k removed the Updates: documentation Improvements or additions to documentation label May 17, 2021
@github-actions github-actions bot added the Updates: documentation Improvements or additions to documentation label May 17, 2021
@Andre601 Andre601 added Type: breaking This change will break previous versions and removed Updates: documentation Improvements or additions to documentation labels May 17, 2021
Andre601 and others added 3 commits May 17, 2021 16:18
* Update README.md
* Improve table
* Add TIMEZONE_OFFSET to readme
* Add DATE_STRING and {DATE} placeholder
* Add DATE_FORMAT to readme
* Improve descriptions
* Update README.md

Co-authored-by: Puneet Gopinath <[email protected]>
Co-authored-by: PuneetGopinath <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@PuneetGopinath
Copy link
Member

PuneetGopinath commented May 17, 2021

1 minute plz don't merge

@abhijoshi2k
Copy link
Member Author

abhijoshi2k commented May 17, 2021

1 minute plz don't merge

I just pushed. 1 sec before your comment

@PuneetGopinath
Copy link
Member

Ok

@Andre601
Copy link
Member

Andre601 commented May 17, 2021

1 minute plz don't merge

Just add the Status: Ready label once your PR is ready for merge.

@abhijoshi2k
Copy link
Member Author

1 minute plz don't merge

Just add the Status: Ready label once your PR is ready for merge.

It's ready.

@abhijoshi2k abhijoshi2k added Status: Ready The Pull request is ready for reviews and getting merged and removed Status: In progress This pr or issue is in progress labels May 17, 2021
@github-actions
Copy link
Contributor

The Pull request of @abhijoshi2k has been marked as Ready!

It can now be reviewed and/or merged by Maintainers.


This is an automated response created by a GitHub Action
Mentioning the bot won't have any effect!

@PuneetGopinath
Copy link
Member

PuneetGopinath commented May 17, 2021

The exact package-lock.json change was the thing I wanted to do by running npm install

@abhijoshi2k
Copy link
Member Author

The exact package-lock.json change was the thing I wanted to do.

Okay. Now I think we can merge

@PuneetGopinath PuneetGopinath merged commit 8ab0583 into main May 17, 2021
@PuneetGopinath PuneetGopinath deleted the updation-time branch May 17, 2021 10:59
@PuneetGopinath
Copy link
Member

This time I by mistake forgot to squash and merge 🤣

@abhijoshi2k
Copy link
Member Author

This time I by mistake forgot to squash and merge 🤣

It's fine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Will be added to next minor release Status: Ready The Pull request is ready for reviews and getting merged Type: breaking This change will break previous versions Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants