Use config file

[PuneetGopinath]

Checks

I have...

• read and understood the Contributing Guidelines
• Updated any nessecary files such as the README.md and/or CHANGELOG.md.

Type of Pull request

• Minor Change
  This Pull request doesn't break existing configuration.
• Major Change
  This Pull request will break existing configuration.
• Bug fix
  This Pull request will fix a (critical) bug.
• Documentation
  This Pull request only changes documentation (README.md, CHANGELOG.md, etc.)
• Other: __________

Description

See #52 for the details, etc.

Closes #52

[abhijoshi2k]

@PuneetGopinath FYI, TIMEZONE_OFFSET is going to be renamed with TIMEZONE
You do not need to change it in any of the current file as I'll do it on other branch and then merge. You just have to take care of it in new YAML

[abhijoshi2k]

@PuneetGopinath please run npm i on your side and commit the new package-lock.json to run build successfully

[PuneetGopinath]

@PuneetGopinath please run npm i on your side and commit the new package-lock.json to run build successfully

That's what I asked you in #52, now I will do it.

[PuneetGopinath]

@abhijoshi2k Can you check the commit "Fix index.js", that whether it will work or not?

[PuneetGopinath]

@abhijoshi2k Why is prettier checking dist/index.js, I think you added dist/index.js to the .prettierignore, so it shoulld check that file

[abhijoshi2k]

@abhijoshi2k Can you check the commit "Fix index.js", that whether it will work or not?

No. that won't work.
You don't need to make any changes to any file other than config.js and parseYaml.js
config.js should export exact same values as it was exporting before

[abhijoshi2k]

Try using spread operator again while exporting. f.e. ...conf

[PuneetGopinath]

@abhijoshi2k Why is prettier checking dist/index.js, I think you added it to the .prettierignore

@abhijoshi2k
EDIT: See https://github.com/Readme-Workflows/recent-activity/pull/53/checks?check_run_id=2645996290

[abhijoshi2k]

@abhijoshi2k Why is prettier checking dist/index.js, I think you added it to the .prettierignore

@abhijoshi2k
EDIT: See https://github.com/Readme-Workflows/recent-activity/pull/53/checks?check_run_id=2645996290

It's programmed to format all files ending with .js. That might be the reason

[PuneetGopinath]

It's programmed to format all files ending with .js. That might be the reason

Can you fix that?

[abhijoshi2k]

It's programmed to format all files ending with .js. That might be the reason

Can you fix that?

I tried. But couldn't. That's fine. It won't cause any issue.

[abhijoshi2k]

@PuneetGopinath I feel there's a better way to structure config.js. Would you like me to make a commit?

[PuneetGopinath]

@PuneetGopinath I feel there's a better way to structure config.js. Would you like me to make a commit?

Sure, that's what I said in #52

I will assign this to my self if you agree with this request and plz help me in the process of doing it.

[PuneetGopinath]

@abhijoshi2k I am receiving too many emails for this failing workflow, can we remove it to run on PRs.

[PuneetGopinath]

@abhijoshi2k You shouldn't use those vars as we are going to remove them in config.js and action.yml

[abhijoshi2k]

@abhijoshi2k You shouldn't use those vars as we are going to remove them in config.js and action.yml

Let's not remove them. It'll automatically take default value and then replace it as per user's YML file.
Users will have a choice between using same yml or separate one

[abhijoshi2k]

@abhijoshi2k I am receiving too many emails for this failing workflow, can we remove it to run on PRs.

It's working on local though. IDK what's the issue here

[abhijoshi2k]

@abhijoshi2k @Andre601 Can you check the updated wiki?

I think the inputs should be shown on top. Also, link to sample.yml is incorrect.

Also, I have updated the disabled_events in sample.yml. You will need to update that in wiki
review_approved is changed to changes_approved.
You need to mention that all of the options are optional.

Instead of giving link to sample.yml, I think we should simply provide the contents of the file on wiki.

[PuneetGopinath]

@abhijoshi2k @Andre601 Can you check the updated wiki?

I think the inputs should be shown on top. Also, link to sample.yml is incorrect.

The link will return a 404 as the file is not in branch main

[PuneetGopinath]

@Andre601 Sorry for updating the wiki, I rebased and force pushed so my commit is dropped.
Can you add the Inputs sections and what @abhijoshi2k requested?
The inputs section can be something like this:

## Inputs

These are the inputs you can supply through github actions (that you can set through the `with` option in a workflow file)

<table>
  <thead>
    <tr>
      <th>Option</th>
      <th>Description</th>
      <th>Default</th>
    </tr>
  </thead>
  <tbody>
    <tr>
      <td><code>GH_USERNAME</code></td>
      <td>The User to get latest activity from</td>
      <td><i>Repository Owner</i></td>
    </tr>
    <tr>
      <td><code>CONFIG_FILE</code></td>
      <td>The location of the configuration file, remember to add `./` before the path to the file.</td>
      <td><i>./.github/recent-activity.config.yml</i></td>
    </tr>
  </tbody>
</table>

[abhijoshi2k]

@abhijoshi2k @Andre601 Can you check the updated wiki?

I think the inputs should be shown on top. Also, link to sample.yml is incorrect.

The link will return a 404 as the file is not in branch main

Okay.

[Andre601]

The link to the sample.yml doesn't work because the file has yet to be added to the main branch.

[Andre601]

Also, I have updated the disabled_events in sample.yml. You will need to update that in wiki
review_approved is changed to changes_approved.
You need to mention that all of the options are optional.

Instead of giving link to sample.yml, I think we should simply provide the contents of the file on wiki.

Updated the wiki.
Also, I intentionally link to the file instead of having a copy of it on the wiki. Reason for that is, that in case of the file changing, we don't have to update the wiki as much...

[abhijoshi2k]

The home and example wiki also need to be updated right? @Andre601

[PuneetGopinath]

The home and example wiki also need to be updated right? @Andre601

@Andre601

[Andre601]

[Andre601]

@Andre601 Can I add a footer in wiki?

Go ahead.

[PuneetGopinath]

@Andre601 Can I add a footer in wiki?

Go ahead.

Check it out now.

[PuneetGopinath]

We have to resolve conflicts

[github-actions]

The Pull request of @PuneetGopinath has been marked as Ready!

It can now be reviewed and/or merged by Maintainers.

---

This is an automated response created by a GitHub Action
Mentioning the bot won't have any effect!