Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom committer #63

Merged
merged 4 commits into from
May 27, 2021
Merged

Add custom committer #63

merged 4 commits into from
May 27, 2021

Conversation

Lorenzo0111
Copy link
Contributor

Checks

I have...

  • read and understood the Contributing Guidelines
  • Updated any nessecary files such as the README.md and/or CHANGELOG.md.

Type of Pull request

  • Minor Change
    This Pull request doesn't break existing configuration.
  • Major Change
    This Pull request will break existing configuration.
  • Bug fix
    This Pull request will fix a (critical) bug.
  • Documentation
    This Pull request only changes documentation (README.md, CHANGELOG.md, etc.)
  • Other: __________

Description

Added an option to edit committer name and email.

Closes #

@welcome
Copy link

welcome bot commented May 26, 2021

Thanks for opening this pull request! Make sure you have read the contributing guidelines, assigned an respective issue (if applicable) to this PR 😇

@Andre601
Copy link
Member

I for my part can't see the real benefit here. But I let the other maintainers give their feedback

@PuneetGopinath
Copy link
Member

PuneetGopinath commented May 27, 2021 •
edited
Loading

Hi @Lorenzo0111!
Thanks for this PR.
But currently this action is in an idle state.
That we announced in our discord server:

🥁 Recent Activity action is idle for 2 weeks 🥁

Hello everyone!
We are sad 😢 to inform you that Recent Activity action is idle 😴 for 2 more weeks.
As we also want to give rest to our maintainers and one of our maintainer (Abishek Joshi), his vivas and sems are gonna start from tomorrow (some exams).
We worked continuously for many days to bring new features and fix bugs.
You can still submit feature requests and bug reports, but we will not be able to finish them as our functionality maintainer (Abishek Joshi) is not available, I (Puneet Gopinath) sometimes can fix bugs and fulfill feature requests, but without approval of Abishek we can't merge PRs, etc.
So we mention that Recent Activity action is idle for 2 more weeks.
That means it is idle till 31 May 2021.

Please wait for Abishek 🙏.

@PuneetGopinath
Copy link
Member

Andre, just update the Changelog.

PuneetGopinath
PuneetGopinath requested changes May 27, 2021
View reviewed changes
src/functions/commitFile.js Outdated Show resolved Hide resolved
@PuneetGopinath PuneetGopinath added minor Will be added to next minor release Priority: low Low priority for this issue/pr. Status: In progress This pr or issue is in progress Type: enhancement New feature or request labels May 27, 2021
@PuneetGopinath
Copy link
Member

Hi @Lorenzo0111.
Can you give permission for maintaners to edit.
Docs: https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
After I merge branch main, can you update the docs in docs/Configuration.md

abhijoshi2k
abhijoshi2k requested changes May 27, 2021
View reviewed changes
Copy link
Member

@abhijoshi2k abhijoshi2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the incorrect variable names in src/functions/commitFile.js and merge latest commits from main branch.
After that, update the docs/Configuration.md

@Lorenzo0111
Copy link
Contributor Author

Hi @Lorenzo0111.
Can you give permission for maintaners to edit.
Docs: https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
After I merge branch main, can you update the docs in docs/Configuration.md

Done
immagine

@PuneetGopinath

This comment has been minimized.

Sign in to view
@PuneetGopinath

This comment has been minimized.

Sign in to view
@PuneetGopinath
Copy link
Member

@Lorenzo0111 Can you resolve the requested changes?

@Lorenzo0111 Lorenzo0111 requested a review from Andre601 as a code owner May 27, 2021 15:10
@Lorenzo0111
Copy link
Contributor Author

@Lorenzo0111 Can you resolve the requested changes?

done

PuneetGopinath
PuneetGopinath requested changes May 27, 2021
View reviewed changes
dist/index.js Outdated
]);
await exec("git", ["config", "--global", "user.name", "readme-bot"]);
await exec("git", ["config", "--global", "user.name", commitName]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also, the same fix is required

PuneetGopinath
PuneetGopinath requested changes May 27, 2021
View reviewed changes
dist/index.js Outdated Show resolved Hide resolved
@PuneetGopinath
Copy link
Member

I requested more changes, @Lorenzo0111

Andre601
Andre601 approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@Andre601 Andre601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't request my review here, since I don't have the proper knowledge of this coding language to give proper feedback

@Lorenzo0111
Copy link
Contributor Author

You shouldn't request my review here, since I don't have the proper knowledge of this coding language to give proper feedback

I didn't requested it. I think it is automatic

@Andre601
Copy link
Member

You shouldn't request my review here, since I don't have the proper knowledge of this coding language to give proper feedback

I didn't requested it. I think it is automatic

True. Just saw it.

@PuneetGopinath
Copy link
Member

You shouldn't request my review here, since I don't have the proper knowledge of this coding language to give proper feedback

He didn't, you are a CODEOWNER

@PuneetGopinath
Copy link
Member

You shouldn't request my review here, since I don't have the proper knowledge of this coding language to give proper feedback

I didn't requested it. I think it is automatic

True. Just saw it.

You have to review it, as their as changes in docs

abhijoshi2k
abhijoshi2k approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@abhijoshi2k abhijoshi2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working properly!

@abhijoshi2k abhijoshi2k added Status: Ready The Pull request is ready for reviews and getting merged and removed Status: In progress This pr or issue is in progress labels May 27, 2021
@abhijoshi2k abhijoshi2k merged commit 490cd0c into Readme-Workflows:main May 27, 2021
@welcome
Copy link

welcome bot commented May 27, 2021

Congrats on merging your first pull request🎉! We are proud of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PuneetGopinath PuneetGopinath PuneetGopinath approved these changes

@abhijoshi2k abhijoshi2k abhijoshi2k approved these changes

@Andre601 Andre601 Andre601 approved these changes

Assignees
No one assigned
Labels
minor Will be added to next minor release Priority: low Low priority for this issue/pr. Status: Ready The Pull request is ready for reviews and getting merged Type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lorenzo0111 @Andre601 @PuneetGopinath @abhijoshi2k