Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Image upload modal not visible completely #618

Closed
6 of 10 tasks
tejaskh3 opened this issue Oct 17, 2024 · 3 comments · Fixed by #619
Closed
6 of 10 tasks

[BUG] Image upload modal not visible completely #618

tejaskh3 opened this issue Oct 17, 2024 · 3 comments · Fixed by #619
Assignees
@mdansarijaved

Comments

@tejaskh3
Copy link
Member

tejaskh3 commented Oct 17, 2024 •
edited
Loading

Issue Description

The close button for image update message modal is behind the navbar, and there is shifting of content also, either make the container small or bring the close button above the navbar that is increase z-indexing.

Expected Behavior

The modal should be visible, but upper part of modal is behind the navbar.

Current Behavior

The close button is not visible on the modal.

screen-capture.28.mp4

Screenshots

Reproducibility

  • This issue is reproducible
  • This issue is not reproducible

Steps to Reproduce

  1. Go to my site
  2. Try changing your profile photo
  3. After successfully updating/uploading your profile picture scroll down you will see the closing button of success modal is behind navbar

Severity/Priority

  • Critical
  • High
  • Medium
  • Low

Additional Information

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.
@tejaskh3 tejaskh3 changed the title Image upload modal not completely visible Image upload modal not visible completely Oct 17, 2024
@tejaskh3 tejaskh3 changed the title Image upload modal not visible completely [BUG] Image upload modal not visible completely Oct 17, 2024
@mdansarijaved
Copy link
Contributor

@tejaskh3 @yesyash @vinit717 My TCR have been approved for this task.

@mdansarijaved
Copy link
Contributor

under the dev=true flag there is "use mobile app" dialog which also have the same issue.
image

mdansarijaved added a commit to mdansarijaved/website-my that referenced this issue Oct 21, 2024
@mdansarijaved
fix: Real-Dev-Squad#618 model z index fixed
b081de7
mdansarijaved added a commit to mdansarijaved/website-my that referenced this issue Oct 21, 2024
@mdansarijaved
fix: Real-Dev-Squad#618 mobile dialog fix
b1d01b4
@mdansarijaved
Copy link
Contributor

@tejaskh3 @yesyash I had some questions will these changes go under dev=true flag ?? and do I need to write test cases for these too?

@mdansarijaved mdansarijaved mentioned this issue Oct 21, 2024
Merged
10 tasks
iamitprakash pushed a commit that referenced this issue Oct 22, 2024
@mdansarijaved
[BUG] Image upload modal not visible completely (#619)
ba61b42 
* fix: #618 model z index fixed

* fix: responsive profile edit button

* fix: #618 mobile dialog fix
@Achintya-Chatterjee Achintya-Chatterjee mentioned this issue Oct 24, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdansarijaved mdansarijaved

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] Image upload modal not visible completely mdansarijaved/website-my
2 participants
@mdansarijaved @tejaskh3