[Live-Site] Feature/loading #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
7289f48
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b03f5dd2.www-rds.pages.dev |
| Branch Preview URL: | https://feature-loading.www-rds.pages.dev |
prerana1821
suggested changes
Sep 14, 2023
There was a problem hiding this comment.
Hey @Pratiyushkumar,
I don't think we need both loading text and the animation.
You can remove the "Loading" text. Also, can the space between the dots decrease a little?
removed loading text only animation is there |
…site-www into feature/loading
iamitprakash
requested review from
iamitprakash and
prakashchoudhary07
and removed request for
prakashchoudhary07 and
iamitprakash
DashDeipayan
requested review from
iamitprakash and
prakashchoudhary07
and removed request for
iamitprakash and
prakashchoudhary07
|
The loader is overall good can we decrease the size of bubbles, a little and make it pink color(for all the three bubbles). |
vinit717
previously approved these changes
Sep 27, 2023
…site-www into feature/loading
satyam73
approved these changes
Sep 28, 2023
vinit717
approved these changes
Sep 28, 2023
Comment on lines
+28
to
+32
| <div class='loading'> | ||
| <span></span> | ||
| <span></span> | ||
| <span></span> | ||
| </div> |
There was a problem hiding this comment.
NIT: this can be broken into a separate component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
What is the change?
There should be a loader shown while kicking out the peers from a live stream, so when we kick peers, there is a delay between the request sent to the backend and the response from the backend, so to cover that delay we are putting a loader.
Is Development Tested?
Change video recording
bandicam.2023-09-20.20-22-02-793.mp4