User Signup Form Validation and Toast Message #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
d60556d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://45553578.www-rds.pages.dev |
| Branch Preview URL: | https://feature-input-validation.www-rds.pages.dev |
shubhamsinghbundela
requested review from
iamitprakash,
rohan09-raj and
vinit717
iamitprakash
requested changes
Sep 19, 2023
iamitprakash
approved these changes
Sep 19, 2023
vinit717
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Closes #654
Parent ticket: Real-Dev-Squad/todo-action-items#178
What is the change?
Allow user to input anything in "firstname" and "lastname" input field
If the input in the "firstname" or "lastname" fields violates certain criteria i.e. input not contain spaces, non-alphabetical characters, numbers, more than 20 character, an error message should be displayed below the respective input field ("firstname" and "lastname") and generateusername button will disable
If the input in both the "firstname" and "lastname" fields meet the criteria, a button will enable and a username should be generated.
When the "sign-in-with-github" session is logged out, and the "generateUsername" button is clicked, A toast message should be displayed.
Feature under feature flag
Is Development Tested?
After Change Video
Kqjzv20NbY.mp4
Test video:
chrome_LwPlDrPZex.mp4