Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/goto page #759

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Feat/goto page #759

merged 4 commits into from
Dec 21, 2023

Conversation

satyam73
Copy link
Member

@satyam73 satyam73 commented Dec 7, 2023 •
edited
Loading

Issue #746

Example : Closes #746

What is the change?

Added goto page for redirection.

Example :
  • Done this
  • Made these changes

Is Development Tested?

  • Yes
  • No

Before / After Change Screenshots

image

Desktop

image

Tablet

image

Mobile
Note :
What to delete and what not to

  • Keep the headings and answer the questions.
  • Delete the examples
  • Delete the description below headings What is the change? & Before/After Screenshots

@satyam73 satyam73 changed the base branch from develop to develop-ember December 7, 2023 08:38
@satyam73 satyam73 marked this pull request as ready for review December 7, 2023 08:38
@satyam73 satyam73 marked this pull request as draft December 7, 2023 08:41
@satyam73 satyam73 marked this pull request as ready for review December 7, 2023 16:03
@shubhamsinghbundela
Copy link
Contributor

Issue

Example : Closes #<issue_number>

What is the change?

Provide a small description in points of what did you change

Example :
  • Done this
  • Made these changes

Is Development Tested?

  • Yes
  • No

Before / After Change Screenshots

For visual or interaction changes. Please provide a video / screenshot.

Example:

Before : Image/Video

After : Image/Video

Note : What to delete and what not to

  • Keep the headings and answer the questions.
  • Delete the examples
  • Delete the description below headings What is the change? & Before/After Screenshots

Fill description

shubhamsinghbundela
shubhamsinghbundela reviewed Dec 8, 2023
View reviewed changes
app/constants/urls.js Show resolved Hide resolved
app/templates/goto.hbs Show resolved Hide resolved
@satyam73 satyam73 self-assigned this Dec 9, 2023
ajoykumardas12
ajoykumardas12 previously approved these changes Dec 10, 2023
View reviewed changes
shubhamsinghbundela
shubhamsinghbundela reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@shubhamsinghbundela shubhamsinghbundela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 13, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d205fde
Status: ✅  Deploy successful!
Preview URL: https://aec29447.www-rds.pages.dev
Branch Preview URL: https://feat-goto-page.www-rds.pages.dev

View logs

@satyam73 satyam73 merged commit 079b6ed into develop-ember Dec 21, 2023
3 checks passed
@satyam73 satyam73 deleted the feat/goto-page branch December 21, 2023 09:06
@satyam73 satyam73 linked an issue Dec 21, 2023 that may be closed by this pull request
[Ember-Migration] Goto Page #746
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsinghbundela shubhamsinghbundela shubhamsinghbundela left review comments

@ajoykumardas12 ajoykumardas12 ajoykumardas12 approved these changes

Assignees

@satyam73 satyam73

Labels
ember-migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ember-Migration] Goto Page
3 participants
@satyam73 @shubhamsinghbundela @ajoykumardas12