Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide events page #791

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Hide events page #791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77d38e3
feat: update home page url
prakashchoudhary07 Dec 27, 2023
4747327
fix: hide events page
prakashchoudhary07 Dec 27, 2023
b48054e
tests: comment events test, will be fixed in #787
prakashchoudhary07 Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/components/header.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,13 @@
class="nav__element"
href={{this.WELCOME_URL}}
>Welcome</a></li>
<li><a
{{! Events section is to be migrated, will use it once its done,
track it here https://github.com/Real-Dev-Squad/website-www/issues/787 }}
{{!-- <li><a
data-test-events
class="nav__element"
href={{this.EVENTS_URL}}
>Events</a></li>
>Events</a></li> --}}
<li><a
data-test-members
class="nav__element"
Expand Down
6 changes: 3 additions & 3 deletions app/constants/urls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const DOMAIN = 'realdevsquad.com';

const APP_URLS = {
production: {
HOME: `${SCHEME}beta.${DOMAIN}`,
HOME: `${SCHEME}${DOMAIN}`,
WELCOME: `${SCHEME}welcome.${DOMAIN}`,
EVENTS: `${SCHEME}${DOMAIN}/events`,
MEMBERS: `${SCHEME}members.${DOMAIN}`,
Expand All @@ -17,7 +17,7 @@ const APP_URLS = {
API_BACKEND: `${SCHEME}api.${DOMAIN}`,
},
staging: {
HOME: `${SCHEME}beta.${DOMAIN}`,
HOME: `${SCHEME}staging-www.${DOMAIN}`,
WELCOME: `${SCHEME}staging-welcome.${DOMAIN}`,
EVENTS: `${SCHEME}staging-www.${DOMAIN}/events`,
MEMBERS: `${SCHEME}staging-members.${DOMAIN}`,
Expand All @@ -29,7 +29,7 @@ const APP_URLS = {
API_BACKEND: `${SCHEME}staging-api.${DOMAIN}`,
},
development: {
HOME: `${SCHEME}beta.${DOMAIN}`,
HOME: `${SCHEME}staging-www.${DOMAIN}`,
WELCOME: `${SCHEME}staging-welcome.${DOMAIN}`,
EVENTS: `${SCHEME}staging-www.${DOMAIN}/events`,
MEMBERS: `${SCHEME}staging-members.${DOMAIN}`,
Expand Down
10 changes: 7 additions & 3 deletions tests/integration/components/header-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module('Integration | Component | header', function (hooks) {
setupRenderingTest(hooks);

test('header elements renders', async function (assert) {
assert.expect(15);
assert.expect(13);

this.setProperties({
isLoggedIn: false,
Expand All @@ -34,8 +34,12 @@ module('Integration | Component | header', function (hooks) {
assert.dom('[data-test-home]').hasAttribute('href', '/');
assert.dom('[data-test-welcome]').hasText('Welcome');
assert.dom('[data-test-welcome]').hasAttribute('href', APPS.WELCOME);
assert.dom('[data-test-events]').hasText('Events');
assert.dom('[data-test-events]').hasAttribute('href', APPS.EVENTS);
/*
TODO: Events section is to be migrated, will use it once its done,
track it here https://github.com/Real-Dev-Squad/website-www/issues/787
*/
// assert.dom('[data-test-events]').hasText('Events');
// assert.dom('[data-test-events]').hasAttribute('href', APPS.EVENTS);
assert.dom('[data-test-members]').hasText('Members');
assert.dom('[data-test-members]').hasAttribute('href', APPS.MEMBERS);
assert.dom('[data-test-status]').hasText('Status');
Expand Down
Loading