subscription feature fixes #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying www-rds with
|
| Latest commit: |
5247dc3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3028d58e.www-rds.pages.dev |
| Branch Preview URL: | https://new-subcription-feature.www-rds.pages.dev |
tejaskh3
changed the title
yesyash
previously approved these changes
Oct 21, 2024
NOTE for approver: Please make sure the ticket for tests is added to the PR description before merging. |
This is the stacked PR for test cases: #945, we can merge stacked PR after this one. |
vinit717
previously approved these changes
Oct 22, 2024
vinit717
dismissed
their stale review
Show error message when user provide wrong phone number
|
Still, I didn't see any error when the user provide wrong information |
I added that message in the placeholder, but I got your point just like tiny site the input box should become red |
|
Achintya-Chatterjee
previously approved these changes
Oct 23, 2024
Achintya-Chatterjee
approved these changes
Oct 23, 2024
MehulKChaudhari
approved these changes
Oct 23, 2024
lakshayman
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Subscription feature (#936) * feat: add form to collect subscription data * feat: add form to collect subscription data * WIP: add ember-phone-input * feat: add not loggedin and subscribed screen and integreate API * feat: fixing bug * fix: bug to show form even if user is already subscribed * fix: urls * fix: urls * fix: urls * delete: service subscribe test * fix: resolve comments * Update app/components/header.hbs Co-authored-by: Mehul Kiran Chaudhari <[email protected]> * fix: comments and remove modal * fix: phone number input * fix: content change * fix: remove card * fix: remove comments * fix:subscribe message --------- Co-authored-by: Vinit khandal <[email protected]> Co-authored-by: Mehul Kiran Chaudhari <[email protected]> * subscription feature fixes (#944) * fix: navbar & css & phone validation * fix: PR comments * feat: add error to in valid input * fix: lint --------- Co-authored-by: Vinit khandal <[email protected]> Co-authored-by: Mehul Kiran Chaudhari <[email protected]>
lakshayman
added a commit
that referenced
this pull request
Oct 24, 2024
* Subscription feature (#936) * feat: add form to collect subscription data * feat: add form to collect subscription data * WIP: add ember-phone-input * feat: add not loggedin and subscribed screen and integreate API * feat: fixing bug * fix: bug to show form even if user is already subscribed * fix: urls * fix: urls * fix: urls * delete: service subscribe test * fix: resolve comments * Update app/components/header.hbs Co-authored-by: Mehul Kiran Chaudhari <[email protected]> * fix: comments and remove modal * fix: phone number input * fix: content change * fix: remove card * fix: remove comments * fix:subscribe message --------- Co-authored-by: Vinit khandal <[email protected]> Co-authored-by: Mehul Kiran Chaudhari <[email protected]> * subscription feature fixes (#944) * fix: navbar & css & phone validation * fix: PR comments * feat: add error to in valid input * fix: lint * rename: phoneNumber to phone (#953) --------- Co-authored-by: TEJAS <[email protected]> Co-authored-by: Vinit khandal <[email protected]> Co-authored-by: Mehul Kiran Chaudhari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 22 oct, 2024
Developer Name: @tejaskh3
Issue Ticket Number:-
Description:
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )
Video removed
Note:
Tests for this feature are in this PR: #945