Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[My Site Migration] migration for user status feature (Part - 1) #975

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

MayankBansal12
Copy link

@MayankBansal12 MayankBansal12 commented Jan 8, 2025

Date: 09-01-25

Developer Name: @MayankBansal12


Issue Ticket Number:-

Description:

This is the Part 1 for the user status migration PR. Refer to PR #963 for the complete version.
In this part, routes, controllers, components for user-status and user-status-modal and related files have been migrated.

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Tested in staging?

  • Yes
  • No

Add relevant Screenshot below ( e.g test coverage etc. )

onboarding
idle
active
ooo
update-ooo
update-ooo-2
test

mobile-responsiveness.mp4
working-demo.mp4

@MayankBansal12 MayankBansal12 changed the title [My Site Migration] migration for user status feature (Part - 2) [My Site Migration] migration for user status feature (Part - 1) Jan 8, 2025
@MayankBansal12 MayankBansal12 marked this pull request as ready for review January 8, 2025 18:53
@shubhdevelop
Copy link
Contributor

add the screenshot of the test coverage you've written, not just passing of all the test cases

config/environment.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
app/components/user-status-modal.js Outdated Show resolved Hide resolved
app/utils/date-conversion.js Outdated Show resolved Hide resolved
app/utils/redirect-auth.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tests/unit/routes/status-test.js Outdated Show resolved Hide resolved
app/controllers/status.js Show resolved Hide resolved
@shubhdevelop
Copy link
Contributor

add screen recording showing mobile responsiveness

@MayankBansal12
Copy link
Author

add the screenshot of the test coverage you've written, not just passing of all the test cases

added the screenshots in Part-2 which contains all the tests for the feature

@MayankBansal12
Copy link
Author

add screen recording showing mobile responsiveness

added the screen recording!

Copy link
Member

@tejaskh3 tejaskh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the commented change and other than that everything lgtm

config/environment.js Outdated Show resolved Hide resolved
@tejaskh3
Copy link
Member

Please update the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[My Site Migration] User Status functionality
4 participants