This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Allows two-wheel-drive rovers #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from parent
…otorized landing gear) to be automated. Also no longer depends on ModuleWheelDamage to say if a wheel is touching the ground or not. Also allows rovers with broken wheels to be automated, *if* there are enough non-broken wheels still touching the ground (i.e. 4, with at least 2 motorized). This can be changed by moving the isGrounded check after the damage check.
|
Well, thanks for advance, man! But you changes are a little bit out of date :D |
|
Landing gear parts use ModuleWheelBase, but not ModuleWheelMotor. (So do landing legs, incidentally, which is why I included the "wheelBase.wheelType != WheelType.LEG" check.) I'll adapt as necessary when your update goes live here. Thanks! |
|
OK, I've adopt your changes as it turns out I'll need rely on two usable gears anyway in case of monstrocities like this: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #5 -- this will allow a rover with two motor wheels and two landing gears to be Poehali'd. Additionally, it no longer depends on ModuleWheelDamage to tell if a wheel is touching the ground or not (it uses a variable from ModuleWheelBase now), so the Karibou and Malemute wheels are less 'cheaty'.
There is one more side effect that I'm okay with, but I'll change it if you prefer: currently, a rover with damaged wheels can still be Poehali'd as long as it has at least four working wheels touching the ground (and two of them are motorized). If you'd rather keep the current behavior of not allowing any broken wheels at all, I can move the brokenness check earlier in the loop.