Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty record {} causes incorrect return type #465

Closed
RebeccaStevens opened this issue May 20, 2024 · 1 comment · Fixed by #466
Closed

Empty record {} causes incorrect return type #465

RebeccaStevens opened this issue May 20, 2024 · 1 comment · Fixed by #466
Labels
Status: Released It's now live. Status: Triage This issue needs to be triaged. Type: Bug Inconsistencies or issues which will cause a problem for users or implementors.

Comments

@RebeccaStevens
Copy link
Owner

Bug Report

Expected behavior

deepmerge({}, { a: 1 })
// type should be: { a: number }

Actual behavior

deepmerge({}, { a: 1 })
// type is: never
@RebeccaStevens RebeccaStevens added Status: Triage This issue needs to be triaged. Type: Bug Inconsistencies or issues which will cause a problem for users or implementors. labels May 20, 2024
RebeccaStevens added a commit that referenced this issue May 20, 2024
@RebeccaStevens
fix: return type when using empty records
3a96ca2 
fix #465
@RebeccaStevens RebeccaStevens mentioned this issue May 20, 2024
Merged
RebeccaStevens added a commit that referenced this issue May 20, 2024
@RebeccaStevens
fix: return type when using empty records
6b4ff3f 
fix #465
github-actions bot pushed a commit that referenced this issue May 20, 2024
@semantic-release-bot
chore(release): 6.0.2 [skip ci]
95164dc 
## [6.0.2](v6.0.1...v6.0.2) (2024-05-20)

### Bug Fixes

* return type when using empty records ([6b4ff3f](6b4ff3f)), closes [#465](#465)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 6.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the Status: Released It's now live. label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Released It's now live. Status: Triage This issue needs to be triaged. Type: Bug Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: return type when using empty records RebeccaStevens/deepmerge-ts
1 participant
@RebeccaStevens