fix(messageView): reposition empty state icon

RedHatInsights · Jul 13, 2020 · 047908c · 047908c
1 parent 96c459e
commit 047908c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/src/components/authentication/__tests__/__snapshots__/authentication.test.js.snap b/src/components/authentication/__tests__/__snapshots__/authentication.test.js.snap
@@ -112,16 +112,6 @@ exports[`Authentication Component should render a non-connected component error:
               <div
                 className="pf-c-empty-state__content"
               >
-                <Title
-                  headingLevel="h2"
-                  size="lg"
-                >
-                  <h2
-                    className="pf-c-title pf-m-lg"
-                  >
-                    t(curiosity-auth.authorizedTitle, [object Object])
-                  </h2>
-                </Title>
                 <EmptyStateIcon
                   icon={[Function]}
                 >
@@ -154,6 +144,16 @@ exports[`Authentication Component should render a non-connected component error:
                     </svg>
                   </LockIcon>
                 </EmptyStateIcon>
+                <Title
+                  headingLevel="h2"
+                  size="lg"
+                >
+                  <h2
+                    className="pf-c-title pf-m-lg"
+                  >
+                    t(curiosity-auth.authorizedTitle, [object Object])
+                  </h2>
+                </Title>
                 <EmptyStateBody>
                   <div
                     className="pf-c-empty-state__body"

diff --git a/src/components/messageView/__tests__/__snapshots__/messageView.test.js.snap b/src/components/messageView/__tests__/__snapshots__/messageView.test.js.snap
@@ -21,15 +21,15 @@ exports[`MessageView Component should render a non-connected component: non-conn
     className="fadein"
     variant="full"
   >
+    <EmptyStateIcon
+      icon={[Function]}
+    />
     <Title
       headingLevel="h2"
       size="lg"
     >
       lorem
     </Title>
-    <EmptyStateIcon
-      icon={[Function]}
-    />
     <EmptyStateBody>
       ipsum
     </EmptyStateBody>

diff --git a/src/components/messageView/messageView.js b/src/components/messageView/messageView.js
@@ -27,12 +27,12 @@ const MessageView = ({ icon, message, pageTitle, title }) => (
   <PageLayout>
     <PageHeader>{pageTitle || helpers.UI_DISPLAY_NAME}</PageHeader>
     <PfEmptyState variant={EmptyStateVariant.full} className="fadein">
+      {icon && <EmptyStateIcon icon={icon} />}
       {title && (
         <Title headingLevel="h2" size="lg">
           {title}
         </Title>
       )}
-      {icon && <EmptyStateIcon icon={icon} />}
       {message && <EmptyStateBody>{message}</EmptyStateBody>}
     </PfEmptyState>
   </PageLayout>