fix(routerContext): sw-1089 page display titles (#1089)

RedHatInsights · Apr 4, 2023 · 3c4de82 · 3c4de82
1 parent 8f1031f
commit 3c4de82
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/src/components/router/__tests__/__snapshots__/routerContext.test.js.snap b/src/components/router/__tests__/__snapshots__/routerContext.test.js.snap
@@ -40,6 +40,14 @@ exports[`RouterContext should apply a hook for useNavigate: navigation push 1`]
 ]
 `;
 
+exports[`RouterContext should apply a hook for useRouteDetail: document title 1`] = `
+[
+  [
+    "t(curiosity-view.title, {"appName":"Subscriptions","context":"RHEL"}) - Subscriptions",
+  ],
+]
+`;
+
 exports[`RouterContext should apply a hook for useRouteDetail: route details, closest 1`] = `
 {
   "detailProps": [

diff --git a/src/components/router/__tests__/routerContext.test.js b/src/components/router/__tests__/routerContext.test.js
@@ -48,7 +48,14 @@ describe('RouterContext', () => {
   });
 
   it('should apply a hook for useRouteDetail', async () => {
-    const { result: exactMatch } = await mountHook(() => useRouteDetail({ useSelector: () => ['rhel'] }));
+    const mockUpdateDocumentTitle = jest.fn();
+    const { result: exactMatch } = await mountHook(() =>
+      useRouteDetail({
+        useChrome: () => ({ updateDocumentTitle: mockUpdateDocumentTitle }),
+        useSelector: () => ['rhel']
+      })
+    );
+    expect(mockUpdateDocumentTitle.mock.calls).toMatchSnapshot('document title');
     expect({
       detailProps: Object.keys(exactMatch),
       isClosest: exactMatch.isClosest,

diff --git a/src/components/router/routerContext.js b/src/components/router/routerContext.js
@@ -114,10 +114,10 @@ const useRouteDetail = ({
 
       // Set document title
       updateDocumentTitle(
-        `${helpers.UI_DISPLAY_NAME}: ${t(`curiosity-view.title`, {
+        `${t(`curiosity-view.title`, {
           appName: helpers.UI_DISPLAY_NAME,
           context: firstMatch?.productGroup
-        })}`
+        })} - ${helpers.UI_DISPLAY_NAME}`
       );
 
       // Set route detail