fix(routing): Use dynamic router basename (#821)

src/AppEntry.js

@@ -9,7 +9,7 @@ import '@patternfly/react-styles/css/components/Select/select.css';
 
 const AppEntry = () => (
   <Provider store={store}>
-    <BrowserRouter basename={routerHelpers.baseName}>
+    <BrowserRouter basename={routerHelpers.dynamicBaseName()}>
       <App />
     </BrowserRouter>
   </Provider>

src/components/authentication/__tests__/__snapshots__/authentication.test.js.snap

@@ -301,7 +301,6 @@ exports[`Authentication Component should return a message on 401 error: 401 erro
 
 exports[`Authentication Component should return a redirect on 418 error: 418 error 1`] = `
 <Redirect
-  baseName="/"
   isForced={false}
   route="/optin"
   routes={
@@ -441,7 +440,6 @@ exports[`Authentication Component should return a redirect on a specific 403 err
 
 exports[`Authentication Component should return a redirect on a specific 403 error and error code: 403 redirect error 1`] = `
 <Redirect
-  baseName="/"
   isForced={false}
   route="/optin"
   routes={

src/components/router/__tests__/__snapshots__/redirect.test.js.snap

@@ -10,7 +10,7 @@ exports[`Redirect Component should handle a forced redirect: forced route 1`] =
 exports[`Redirect Component should handle a forced redirect: forced route, replace 1`] = `
 Array [
   Array [
-    "/dolor?dolor=sit",
+    "/subscriptions/dolor?dolor=sit",
   ],
 ]
 `;

src/components/router/__tests__/redirect.test.js

@@ -29,7 +29,7 @@ describe('Redirect Component', () => {
         mockReplace.mockClear();
       },
       {
-        url: 'http://lorem/ipsum?dolor=sit'
+        url: 'http://lorem/subscriptions/ipsum?dolor=sit'
       }
     );
   });

src/components/router/redirect.js

@@ -8,14 +8,15 @@ import { helpers } from '../../common';
  * A routing redirect.
  *
  * @param {object} props
- * @param {string} props.baseName
  * @param {boolean} props.isForced
  * @param {string} props.route
  * @param {string} props.routes
  * @param {string} props.url
  * @returns {Node}
  */
-const Redirect = ({ baseName, isForced, route, routes, url }) => {
+const Redirect = ({ isForced, route, routes, url }) => {
+  const baseName = routerHelpers.dynamicBaseName();
+
   /**
    * Bypass router, force the location.
    */
@@ -40,11 +41,10 @@ const Redirect = ({ baseName, isForced, route, routes, url }) => {
 /**
  * Prop types.
  *
- * @type {{isRedirect: boolean, route: string, routes: Array, isReplace: boolean, baseName: string, url: string,
+ * @type {{isRedirect: boolean, route: string, routes: Array, isReplace: boolean, url: string,
  *    isForced: boolean}}
  */
 Redirect.propTypes = {
-  baseName: PropTypes.string,
   isForced: PropTypes.bool,
   route: PropTypes.string,
   routes: PropTypes.array,
@@ -54,11 +54,10 @@ Redirect.propTypes = {
 /**
  * Default props.
  *
- * @type {{isRedirect: boolean, route: string, routes: Array, isReplace: boolean, baseName: string, url: string,
+ * @type {{isRedirect: boolean, route: string, routes: Array, isReplace: boolean, url: string,
  *    isForced: boolean}}
  */
 Redirect.defaultProps = {
-  baseName: routerHelpers.baseName,
   isForced: false,
   route: null,
   routes: routerHelpers.routes,

src/components/router/router.js

@@ -59,7 +59,7 @@ const Router = ({ routes } = {}) => {
               };
 
               const routeDetail = {
-                baseName: routerHelpers.baseName,
+                baseName: routerHelpers.dynamicBaseName(),
                 errorRoute: activateOnErrorRoute,
                 routes,
                 routeItem: { ...item },