fix(testing): platform component import exceptions (#386)

RedHatInsights · Aug 25, 2020 · bc355eb · bc355eb
1 parent 74ff231
commit bc355eb
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 5 deletions.
diff --git a/src/components/authentication/authentication.js b/src/components/authentication/authentication.js
@@ -1,7 +1,7 @@
 import React, { Component } from 'react';
 import PropTypes from 'prop-types';
 import { BinocularsIcon, LockIcon } from '@patternfly/react-icons';
-import { Maintenance } from '@redhat-cloud-services/frontend-components/components/Maintenance';
+import { Maintenance } from '@redhat-cloud-services/frontend-components/components/cjs/Maintenance';
 import { connectRouter, reduxActions, reduxSelectors } from '../../redux';
 import { rhsmApiTypes } from '../../types';
 import { helpers } from '../../common';

diff --git a/tests/__snapshots__/platform.test.js.snap b/tests/__snapshots__/platform.test.js.snap
@@ -1,13 +1,13 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Platform Configuration should have a name reference that matches configuration: ui name 1`] = `
+exports[`Platform Configuration, Build should have a name reference that matches configuration: ui name 1`] = `
 Array [
   "REACT_APP_UI_NAME=subscriptions",
   "",
 ]
 `;
 
-exports[`Platform Configuration should have a proxy configuration with path references that match configuration: proxy references 1`] = `
+exports[`Platform Configuration, Build should have a proxy configuration with path references that match configuration: proxy references 1`] = `
 Array [
   "'/apps/subscriptions': {",
   "'/beta/apps/subscriptions': {",
@@ -19,11 +19,13 @@ Array [
 ]
 `;
 
-exports[`Platform Configuration should have path references that match configuration: path references 1`] = `
+exports[`Platform Configuration, Build should have path references that match configuration: path references 1`] = `
 Array [
   "PUBLIC_URL=\${UI_DEPLOY_PATH_PREFIX}/apps/subscriptions/",
   "REACT_APP_CONFIG_SERVICE_LOCALES=\${UI_DEPLOY_PATH_PREFIX}/apps/subscriptions/locales/locales.json",
   "REACT_APP_CONFIG_SERVICE_LOCALES_PATH=\${UI_DEPLOY_PATH_PREFIX}/apps/subscriptions/locales/{{lng}}.json",
   "",
 ]
 `;
+
+exports[`Platform Configuration, Build should use direct imports for platform components, with exceptions: direct import exceptions 1`] = `Array []`;
diff --git a/tests/platform.test.js b/tests/platform.test.js
@@ -1,7 +1,7 @@
 const { execSync } = require('child_process');
 const packageJson = require('../package');
 
-describe('Platform Configuration', () => {
+describe('Platform Configuration, Build', () => {
   it('should have a name reference that matches configuration', () => {
     const envFile = './.env';
     const { appname } = packageJson.insights;
@@ -30,4 +30,19 @@ describe('Platform Configuration', () => {
         .map(value => value.trim())
     ).toMatchSnapshot('proxy references');
   });
+
+  it('should use direct imports for platform components, with exceptions', () => {
+    const srcDir = 'src';
+    const output = execSync(
+      `echo "$(cd ./${srcDir} && git grep -n -E "(@redhat-cloud-services/frontend-components/components/)")"`
+    );
+
+    expect(
+      output
+        .toString()
+        .trim()
+        .split(/[\n\r]/g)
+        .filter(str => !/\/(cjs|esm)\//.test(str))
+    ).toMatchSnapshot('direct import exceptions');
+  });
 });