fix(routerHelpers): issues/218 dynamic base name tests

* in addition to beta path, include root path checks
RedHatInsights · Mar 23, 2020 · e235b1c · e235b1c
1 parent 17a2fab
commit e235b1c
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 9 deletions.
diff --git a/src/components/router/__tests__/__snapshots__/routerHelpers.test.js.snap b/src/components/router/__tests__/__snapshots__/routerHelpers.test.js.snap
@@ -1,12 +1,18 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`RouterHelpers should return a generated baseName: app base lorem base name 1`] = `"/beta/appName"`;
+exports[`RouterHelpers should return a generated baseName using NO path prefix: app lorem route name 1`] = `"/appName"`;
 
-exports[`RouterHelpers should return a generated baseName: app base name 1`] = `"/appName"`;
+exports[`RouterHelpers should return a generated baseName using NO path prefix: empty pathPrefix: app base name 1`] = `"/appName"`;
 
-exports[`RouterHelpers should return a generated baseName: beta app base name 1`] = `"/beta/appName"`;
+exports[`RouterHelpers should return a generated baseName using NO path prefix: root reference pathPrefix: app base name 1`] = `"/appName"`;
 
-exports[`RouterHelpers should return a generated baseName: beta app lorem route name 1`] = `"/beta/appName"`;
+exports[`RouterHelpers should return a generated baseName using NO path prefix: undefined pathPrefix: app base name 1`] = `"/appName"`;
+
+exports[`RouterHelpers should return a generated baseName using a beta path prefix: app base name 1`] = `"/appName"`;
+
+exports[`RouterHelpers should return a generated baseName using a beta path prefix: beta app base name 1`] = `"/beta/appName"`;
+
+exports[`RouterHelpers should return a generated baseName using a beta path prefix: beta app lorem route name 1`] = `"/beta/appName"`;
 
 exports[`RouterHelpers should return navigation and route details that align to location: detail: match specific path navigation 1`] = `
 Object {

diff --git a/src/components/router/__tests__/routerHelpers.test.js b/src/components/router/__tests__/routerHelpers.test.js
@@ -9,20 +9,42 @@ describe('RouterHelpers', () => {
     expect(getNavRouteDetail).toBeDefined();
   });
 
-  it('should return a generated baseName', () => {
+  it('should return a generated baseName using NO path prefix', () => {
     expect(
       dynamicBaseName({
         pathName: '/appName',
-        pathPrefix: '/beta'
+        pathPrefix: ''
       })
-    ).toMatchSnapshot('app base name');
+    ).toMatchSnapshot('empty pathPrefix: app base name');
 
     expect(
       dynamicBaseName({
-        pathName: '/beta/appName',
+        pathName: '/appName'
+      })
+    ).toMatchSnapshot('undefined pathPrefix: app base name');
+
+    expect(
+      dynamicBaseName({
+        pathName: '/appName',
+        pathPrefix: '/'
+      })
+    ).toMatchSnapshot('root reference pathPrefix: app base name');
+
+    expect(
+      dynamicBaseName({
+        pathName: '/appName/loremRoute',
+        pathPrefix: ''
+      })
+    ).toMatchSnapshot('app lorem route name');
+  });
+
+  it('should return a generated baseName using a beta path prefix', () => {
+    expect(
+      dynamicBaseName({
+        pathName: '/appName',
         pathPrefix: '/beta'
       })
-    ).toMatchSnapshot('app base lorem base name');
+    ).toMatchSnapshot('app base name');
 
     expect(
       dynamicBaseName({