Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rhsmServices,redux): issues/10 inventory guests api, state #330

Merged
merged 2 commits into from
Jun 29, 2020
Merged

fix(rhsmServices,redux): issues/10 inventory guests api, state #330

merged 2 commits into from
Jun 29, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jun 29, 2020 •
edited
Loading

What's included

  • fix(rhsmServices,redux): issues/10 inventory guests, state
    • build, dotenv host inventory guest API endpoint added
    • redux actions, reducers, types for inventory guests
    • rhsmServices, add base host inventory guests API
    • rhsmApiTypes, common API response types, inventory guests
  • fix(messageView): reposition empty state icon

Notes

  • Behind the scenes minor updates for RHSM guests inventory

How to test

Local run check

A minimal "mock" check can be run locally.

This is not a good indicator of overall state functionality. Base unit tests, and comparisons to existing state/redux management implementations, should be used for functionality confirmation.

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. open the browser dev console and type 
    curiosity.rhsmServices.getHostsInventoryGuests('RHEL')
  4. a corresponding mock response should appear under the dev tools "network" tab

Example

Screen Shot 2020-06-29 at 11 38 59 AM

Updates issue/story

#10
relates #291

cdcabrera
cdcabrera commented Jun 29, 2020
View reviewed changes
Copy link
Member Author

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RHSM usage types missing,

@cdcabrera
fix(rhsmServices,redux): issues/10 inventory guests, state (RedHatIns…
ca03160 
…ights#330)

* build, dotenv host inventory guest API endpoint added
* redux actions, reducers, types for inventory guests
* rhsmServices, add base host inventory guests API
* rhsmApiTypes, common API response types, inventory guests
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2020 •
edited
Loading

Codecov Report

Merging #330 into ci will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #330      +/-   ##
==========================================
+ Coverage   92.40%   92.44%   +0.03%     
==========================================
  Files          55       55              
  Lines        1330     1336       +6     
  Branches      313      315       +2     
==========================================
+ Hits         1229     1235       +6     
  Misses         86       86              
  Partials       15       15
Impacted Files Coverage Δ
src/components/messageView/messageView.js 100.00% <ø> (ø)
src/redux/reducers/inventoryReducer.js 100.00% <ø> (ø)
src/redux/actions/rhsmActions.js 100.00% <100.00%> (ø)
src/redux/types/rhsmTypes.js 100.00% <100.00%> (ø)
src/services/rhsmServices.js 100.00% <100.00%> (ø)
src/types/rhsmApiTypes.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 975ec6e...ca03160. Read the comment docs.

@cdcabrera cdcabrera merged commit 6b49253 into RedHatInsights:ci Jun 29, 2020
This was referenced Jun 29, 2020
Closed
Merged
Merged
cdcabrera added a commit that referenced this pull request Jul 13, 2020
@cdcabrera
fix(rhsmServices,redux): issues/10 inventory guests, state (#330)
c08e9b9 
* build, dotenv host inventory guest API endpoint added
* redux actions, reducers, types for inventory guests
* rhsmServices, add base host inventory guests API
* rhsmApiTypes, common API response types, inventory guests
cdcabrera added a commit that referenced this pull request Jul 20, 2020
@cdcabrera
fix(rhsmServices,redux): issues/10 inventory guests, state (#330)
4c216b1 
* build, dotenv host inventory guest API endpoint added
* redux actions, reducers, types for inventory guests
* rhsmServices, add base host inventory guests API
* rhsmApiTypes, common API response types, inventory guests
@cdcabrera cdcabrera mentioned this pull request Jul 24, 2020
Merged
cdcabrera added a commit that referenced this pull request Jul 28, 2020
@cdcabrera
fix(rhsmServices,redux): issues/10 inventory guests, state (#330)
17a87b3 
* build, dotenv host inventory guest API endpoint added
* redux actions, reducers, types for inventory guests
* rhsmServices, add base host inventory guests API
* rhsmApiTypes, common API response types, inventory guests
@cdcabrera cdcabrera mentioned this pull request Jul 28, 2020
Merged
cdcabrera added a commit that referenced this pull request Jul 30, 2020
@cdcabrera
fix(rhsmServices,redux): issues/10 inventory guests, state (#330)
3b48997 
* build, dotenv host inventory guest API endpoint added
* redux actions, reducers, types for inventory guests
* rhsmServices, add base host inventory guests API
* rhsmApiTypes, common API response types, inventory guests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdcabrera @codecov-commenter