Environment Sync, Dev to Stage (CI/QA-beta to Prod-beta) PF4 requested updates #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* build, dotenv host inventory API endpoint * redux actions, reducers, types for inventory * rhsmServices, add base host inventory API * rhsmApiTypes, inventory API response types
* build, jsdoc annotation updates
* chartArea, label attribute fix, note
* graphCardHelpers, c3GraphCardHelpers, use Intl.NumberFormat * tests, expand tick format checks
* build, commit lint checks adjusted for rebase
* helpers, expose default locale, description * graphCardHelpers, apply helper default locale * userServices, apply helper default locale
* graphCardHelpers, apply abbreviation fallback
* chartArea, large graph widths throw inaccurate voronoi x coords
* graphCardChartLegend, legend tooltips, apply product context, i18n * i18n, locale strings for en-US, test update for locale keys
* tourView, component removed * i18n, remove tourView locale strings * routerTypes, component removed * tests, dist/integration file check
* tests, apply component displayNames to snapshots * build, local dev run updates, header, branch parameter * build, npm platform packages patched * build, npm pf-react icons, tokens, styles, charts * build, victory charts update sync to pf charts update
* graphCard, c3, cardTitle component * graphCardChartLegend, c3, tooltip distance * optinView, cardTitle and flex layout * pageHeader, revert to pf title component * select, isExpanded to isOpen prop * toolbar, dataToolbar to toolbar component rename * style, card header
* build, platform specific npm resources * chartArea, fix resize method, relates to left nav * pageHeader, revert title to platform version * redux, middleware, reducer, types, update notifications import * styles, move css files to src/index.js to avoid breaking sass
* build, dotenv host inventory guest API endpoint added * redux actions, reducers, types for inventory guests * rhsmServices, add base host inventory guests API * rhsmApiTypes, common API response types, inventory guests
Codecov Report
@@ Coverage Diff @@
## stage #331 +/- ##
==========================================
+ Coverage 92.31% 92.44% +0.12%
==========================================
Files 55 55
Lines 1288 1336 +48
Branches 301 315 +14
==========================================
+ Hits 1189 1235 +46
- Misses 84 86 +2
Partials 15 15
Continue to review full report at Codecov.
|
This was referenced Jul 2, 2020
ruda
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
I looked into all changes, notice the inclusion of localization stuff, a bunch of renames (like @Property to @param). Template changes (CardHead to CardTitle), some URLs changes (components/section to components/cjs/Sections). The inclusion of Host information and guest information. Components renaming (<Component to <Button). So for my general review, it looks good to me.
|
As of 10:40 EST chrome changes have merged, merging ours. Cron job should kick off in a bit once the build merge completes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits
Features
Chores
Bug Fixes
Notes
This PR is a temporary sync only, it will not be merged into Prod-stable directly.
The below process is based on the remaining requested platform environment syncs and still allows Curiosity to follow its normal release cadence after 7/13/2020
CI/QA-beta to Prod-beta), by 7/13/2020CI/QA-beta to CI/QA-stable to Prod-beta), this meets the 7/20/2020 requirement by still following our normal release cycle/processProd-beta to Prod-stable), this meets the 7/30/2020 requirement by still following our normal release cycle/processRelated issues
#296
Additional reviewers
@ruda