Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/10 updates, select toggle prop, expanded rhsmTypes, renamed "graphQuery" to "query" #360

Merged
merged 3 commits into from
Jul 31, 2020
Merged

Issues/10 updates, select toggle prop, expanded rhsmTypes, renamed "graphQuery" to "query" #360

merged 3 commits into from
Jul 31, 2020

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(select): issues/10 pf toggleIcon prop, toggleText
  • fix(redux): issues/10 expand rhsmTypes for filtering

    • rhsmTypes, add filter types, align naming
    • rhsmServices, expand mock
    • toolbar, rename SLA rhsmType
    • viewReducer, apply filter types
  • fix(graphCard,rhelView,openshiftView): issues/10 query prop

    • graphCard, c3GraphCard, prop graphQuery to query
    • rhelView, openshiftView, toolbar, graphQuery to query
    • redux, viewReducer, selectors, graphQuery to query

Notes

  • Incremental behind the scenes commits, ground work for system inventory
  • The rename for "graphQuery" to "query" is aimed at a more generic cross component prop. To be used in toolbar, inventory, etc.
    • Also takes into consideration a possible use of React context, where "viewId" "query" and "productId" could all be applied

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test

Example

...

Updates issue/story

Updates #10

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jul 31, 2020
@cdcabrera
fix(select): issues/10 pf toggleIcon prop, toggleText (RedHatInsights…
452d80f 
…#360)
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jul 31, 2020
@cdcabrera
fix(redux): issues/10 expand rhsmTypes for filtering (RedHatInsights#360
cb10388 
)

* rhsmTypes, add filter types, align naming
* rhsmServices, expand mock
* toolbar, rename SLA rhsmType
* viewReducer, apply filter types
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jul 31, 2020
@cdcabrera
fix(graphCard,rhelView,openshiftView): issues/10 query prop (RedHatIn…
34e5796 
…sights#360)

* graphCard, c3GraphCard, prop graphQuery to query
* rhelView, openshiftView, toolbar, graphQuery to query
* redux, viewReducer, selectors, graphQuery to query
@cdcabrera cdcabrera force-pushed the issues/10-inventory-guests branch from a548636 to 34e5796 Compare July 31, 2020 19:11
cdcabrera added 3 commits July 31, 2020 15:22
@cdcabrera
fix(select): issues/10 pf toggleIcon prop, toggleText (RedHatInsights…
b362fd0 
…#360)
@cdcabrera
fix(redux): issues/10 expand rhsmTypes for filtering (RedHatInsights#360
580de65 
)

* rhsmTypes, add filter types, align naming
* rhsmServices, expand mock
* toolbar, rename SLA rhsmType
* viewReducer, apply filter types
@cdcabrera
fix(graphCard,rhelView,openshiftView): issues/10 query prop (RedHatIn…
28057c8 
…sights#360)

* graphCard, c3GraphCard, prop graphQuery to query
* rhelView, openshiftView, toolbar, graphQuery to query
* redux, viewReducer, selectors, graphQuery to query
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2020 •
edited
Loading

Codecov Report

Merging #360 into ci will increase coverage by 0.04%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #360      +/-   ##
==========================================
+ Coverage   92.40%   92.44%   +0.04%     
==========================================
  Files          61       61              
  Lines        1475     1483       +8     
  Branches      348      348              
==========================================
+ Hits         1363     1371       +8     
  Misses         98       98              
  Partials       14       14
Impacted Files Coverage Δ
src/redux/selectors/graphCardSelectors.js 100.00% <ø> (ø)
src/services/rhsmServices.js 100.00% <ø> (ø)
src/components/toolbar/toolbar.js 95.23% <80.00%> (ø)
src/components/c3GraphCard/c3GraphCard.js 88.67% <100.00%> (ø)
src/components/form/select.js 100.00% <100.00%> (ø)
src/components/graphCard/graphCard.js 83.67% <100.00%> (ø)
src/components/openshiftView/openshiftView.js 100.00% <100.00%> (ø)
src/components/rhelView/rhelView.js 100.00% <100.00%> (ø)
src/redux/reducers/viewReducer.js 100.00% <100.00%> (ø)
src/redux/selectors/viewSelectors.js 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e830b51...28057c8. Read the comment docs.

@cdcabrera cdcabrera force-pushed the issues/10-inventory-guests branch from 34e5796 to 28057c8 Compare July 31, 2020 19:31
@cdcabrera cdcabrera merged commit 41018b7 into RedHatInsights:ci Jul 31, 2020
cdcabrera added a commit that referenced this pull request Jul 31, 2020
@cdcabrera
fix(select): issues/10 pf toggleIcon prop, toggleText (#360)
0ee09bd
cdcabrera added a commit that referenced this pull request Jul 31, 2020
@cdcabrera
fix(redux): issues/10 expand rhsmTypes for filtering (#360)
b83456b 
* rhsmTypes, add filter types, align naming
* rhsmServices, expand mock
* toolbar, rename SLA rhsmType
* viewReducer, apply filter types
@cdcabrera cdcabrera mentioned this pull request Jul 31, 2020
Closed
10 tasks
cdcabrera added a commit that referenced this pull request Jul 31, 2020
@cdcabrera
fix(select): issues/10 pf toggleIcon prop, toggleText (#360)
c0cc484
cdcabrera added a commit that referenced this pull request Jul 31, 2020
@cdcabrera
fix(redux): issues/10 expand rhsmTypes for filtering (#360)
f2f8948 
* rhsmTypes, add filter types, align naming
* rhsmServices, expand mock
* toolbar, rename SLA rhsmType
* viewReducer, apply filter types
cdcabrera added a commit that referenced this pull request Jul 31, 2020
@cdcabrera
fix(graphCard,rhelView,openshiftView): issues/10 query prop (#360)
d20307b 
* graphCard, c3GraphCard, prop graphQuery to query
* rhelView, openshiftView, toolbar, graphQuery to query
* redux, viewReducer, selectors, graphQuery to query
@cdcabrera cdcabrera mentioned this pull request Aug 6, 2020
Merged
cdcabrera added a commit that referenced this pull request Aug 6, 2020
@cdcabrera
fix(select): issues/10 pf toggleIcon prop, toggleText (#360)
2b73801
cdcabrera added a commit that referenced this pull request Aug 6, 2020
@cdcabrera
fix(redux): issues/10 expand rhsmTypes for filtering (#360)
e278f69 
* rhsmTypes, add filter types, align naming
* rhsmServices, expand mock
* toolbar, rename SLA rhsmType
* viewReducer, apply filter types
cdcabrera added a commit that referenced this pull request Aug 6, 2020
@cdcabrera
fix(graphCard,rhelView,openshiftView): issues/10 query prop (#360)
d13abfb 
* graphCard, c3GraphCard, prop graphQuery to query
* rhelView, openshiftView, toolbar, graphQuery to query
* redux, viewReducer, selectors, graphQuery to query
@cdcabrera cdcabrera mentioned this pull request Aug 11, 2020
Merged
cdcabrera added a commit that referenced this pull request Aug 17, 2020
@cdcabrera
fix(select): issues/10 pf toggleIcon prop, toggleText (#360)
dbd858d
cdcabrera added a commit that referenced this pull request Aug 17, 2020
@cdcabrera
fix(redux): issues/10 expand rhsmTypes for filtering (#360)
7a4cfa3 
* rhsmTypes, add filter types, align naming
* rhsmServices, expand mock
* toolbar, rename SLA rhsmType
* viewReducer, apply filter types
cdcabrera added a commit that referenced this pull request Aug 17, 2020
@cdcabrera
fix(graphCard,rhelView,openshiftView): issues/10 query prop (#360)
2ac827c 
* graphCard, c3GraphCard, prop graphQuery to query
* rhelView, openshiftView, toolbar, graphQuery to query
* redux, viewReducer, selectors, graphQuery to query
@cdcabrera cdcabrera mentioned this pull request Aug 21, 2020
Merged
cdcabrera added a commit that referenced this pull request Aug 24, 2020
@cdcabrera
fix(select): issues/10 pf toggleIcon prop, toggleText (#360)
c225f01
cdcabrera added a commit that referenced this pull request Aug 24, 2020
@cdcabrera
fix(redux): issues/10 expand rhsmTypes for filtering (#360)
34d9b0c 
* rhsmTypes, add filter types, align naming
* rhsmServices, expand mock
* toolbar, rename SLA rhsmType
* viewReducer, apply filter types
cdcabrera added a commit that referenced this pull request Aug 24, 2020
@cdcabrera
fix(graphCard,rhelView,openshiftView): issues/10 query prop (#360)
2b6019d 
* graphCard, c3GraphCard, prop graphQuery to query
* rhelView, openshiftView, toolbar, graphQuery to query
* redux, viewReducer, selectors, graphQuery to query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdcabrera @codecov-commenter