Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft release 0.1.19, Sync Test to Stage #376

Merged
merged 16 commits into from
Aug 17, 2020
Merged

Draft release 0.1.19, Sync Test to Stage #376

merged 16 commits into from
Aug 17, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Aug 11, 2020

Features

  1. rhelView, issues/305 add sub heading (feat(rhelView, openshiftView): issues/305 add sub heading #348) (3569e0d)
  2. toolbar issues/10 add usage filter (feat(toolbar): issues/10 add usage filter #361) (4137730)

Bug Fixes

  1. pageHeader issues/305 add bottom margin to h1 (fix(pageHeader): issues/305 add bottom margin to h1 #357) (a945a6c)
  2. i18n,translate issues/354 remove withTranslation (fix(i18n,translate): issues/354 remove withTranslation #355) (1f87648)
  3. select issues/10 pf toggleIcon prop, toggleText (Issues/10 updates, select toggle prop, expanded rhsmTypes, renamed "graphQuery" to "query" #360) (2b73801)
  4. redux issues/10 expand rhsmTypes for filtering (Issues/10 updates, select toggle prop, expanded rhsmTypes, renamed "graphQuery" to "query" #360) (e278f69)
  5. graphCard,rhelView,openshiftView issues/10 query prop (Issues/10 updates, select toggle prop, expanded rhsmTypes, renamed "graphQuery" to "query" #360) (d13abfb)
  6. queryTypes issues/10 rhsm to query type (feat(toolbar): issues/10 add usage filter #361) (89b2588)
  7. testing commit message length (fix(testing): commit message length #366) (f322258)
  8. toolbar issues/10 default usage filter category (fix(toolbar): issues/10 default usage filter category #368) (a7df4ef)
  9. pageHeader issues/367 subheading external link icon (fix(pageHeader): update subheading external link icon #369) (b73c094)
  10. tourView issues/359 remove vestigial tour stylesheet (chore(tourView): issues/359 remove vestigial tour stylesheet #370) (2f5f361)
  11. pageHeader issues/305 apply locale product context (fix(pageHeader): issues/305 apply locale product context #371) (51234d3)
  12. toolbar issues/377 openshiftView, remove usage filter (fix(toolbar): issues/377 openshiftView, remove usage filter #378) (2a97ca4)

Chores

  1. build issues/333 update min test coverage (chore(build): issues/333 update min test coverage #363) (cc2e920)
  2. build issues/335 update Node 10 references to 12 (chore(build): update Node 10 references to Node 12 #364) (8a33670)

zanewoodfin and others added 15 commits August 6, 2020 00:14
* build, platform package update for h1
* pageHeader, pf class added
* style, file names for consistency
* i18n, replace withTranslation new HOC, use translate function
* redux, remove withTranslation convenience HOCs
* rhsmTypes, add filter types, align naming
* rhsmServices, expand mock
* toolbar, rename SLA rhsmType
* viewReducer, apply filter types
* graphCard, c3GraphCard, prop graphQuery to query
* rhelView, openshiftView, toolbar, graphQuery to query
* redux, viewReducer, selectors, graphQuery to query
* graphCard, c3graphCard, filter to query name
* queryTypes, rhsmTypes, filter to query, align naming
* toolbar, apply query SLA type
* viewReducer, apply query types
* i18n, locale strings for usage
* toolbar, toolbarTypes, add usage filter
* redux, middleware, multiActionMiddleware, add array of actions
* redux, reducers, types, toolbar addtions
* styles, add toolbar styles
* toolbar, default filter category, soft filter reset
* locale, i18n, appName, product context strings
* openshiftView, rhelView, apply appName, product context
* pageHeader, appName param, product context
* table, apply appName clean up
@cdcabrera cdcabrera requested a review from ntkathole August 11, 2020 21:55
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2020

Codecov Report

Merging #376 into stage will decrease coverage by 0.00%.
The diff coverage is 96.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##            stage     #376      +/-   ##
==========================================
- Coverage   92.41%   92.40%   -0.01%     
==========================================
  Files          61       64       +3     
  Lines        1476     1528      +52     
  Branches      349      355       +6     
==========================================
+ Hits         1364     1412      +48     
- Misses         98      101       +3     
- Partials       14       15       +1     
Impacted Files Coverage Δ
src/components/graphCard/graphCardChartTooltip.js 100.00% <ø> (ø)
src/components/table/table.js 88.09% <ø> (-0.28%) ⬇️
src/components/table/tableSkeleton.js 100.00% <ø> (ø)
src/redux/selectors/graphCardSelectors.js 100.00% <ø> (ø)
src/redux/types/index.js 100.00% <ø> (ø)
src/redux/types/rhsmTypes.js 100.00% <ø> (ø)
src/services/rhsmServices.js 100.00% <ø> (ø)
src/components/toolbar/toolbar.js 91.07% <91.66%> (-4.39%) ⬇️
src/components/authentication/authentication.js 60.60% <100.00%> (ø)
src/components/c3GraphCard/c3GraphCard.js 88.67% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 732120a...2a97ca4. Read the comment docs.

@cdcabrera cdcabrera added the blocked Prevented from continuing label Aug 12, 2020
@cdcabrera
Copy link
Member Author

This is temporarily blocked until we can apply a disable for the "usage" filter for the Openshift product display, see #377

* graphCard,c3GraphCard, switch redux granularity type
* locale, i18n, switch toolbar strings to context
* openshiftView, rhelView, apply filters for toolbar
* redux, queryTypes, viewReducer, granularity, sla, usage types
* toolbar, convert to config based filter display
* toolbarTypes, use context for locale strings
@cdcabrera cdcabrera removed the blocked Prevented from continuing label Aug 13, 2020
@cdcabrera
Copy link
Member Author

@ntkathole we've removed the unblocked tag. The changes for applying only the SLA filter to the OpenShift product view are within the CI-stable/QA-stable environments and ready for your review!

Screen Shot 2020-08-13 at 5 18 00 PM
Screen Shot 2020-08-13 at 5 17 12 PM

@cdcabrera cdcabrera mentioned this pull request Aug 13, 2020
1 task
Copy link
Member

@ntkathole ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Filters looks good 👍

@cdcabrera cdcabrera merged commit 7cab409 into stage Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants