Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageHeader): issues/305 apply locale product context #371

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Aug 6, 2020

What's included

  • fix(pageHeader): issues/305 apply locale product context
    • locale, i18n, appName, product context strings
    • openshiftView, rhelView, apply appName, product context
    • pageHeader, appName param, product context
    • table, apply appName clean up

Notes

  • behind the scenes optimization

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test

Example

...

Updates issue/story

updates #305
updates #10

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2020

Codecov Report

Merging #371 into ci will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #371   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files          64       64           
  Lines        1528     1528           
  Branches      355      355           
=======================================
  Hits         1413     1413           
  Misses        100      100           
  Partials       15       15           
Impacted Files Coverage Δ
src/components/openshiftView/openshiftView.js 100.00% <ø> (ø)
src/components/pageLayout/pageHeader.js 100.00% <ø> (ø)
src/components/rhelView/rhelView.js 100.00% <ø> (ø)
src/components/table/table.js 88.09% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 981ac6a...f0de8b4. Read the comment docs.

* locale, i18n, appName, product context strings
* openshiftView, rhelView, apply appName, product context
* pageHeader, appName param, product context
* table, apply appName clean up
@cdcabrera cdcabrera mentioned this pull request Aug 6, 2020
10 tasks
@cdcabrera cdcabrera merged commit aa88ec9 into RedHatInsights:ci Aug 6, 2020
cdcabrera added a commit that referenced this pull request Aug 6, 2020
* locale, i18n, appName, product context strings
* openshiftView, rhelView, apply appName, product context
* pageHeader, appName param, product context
* table, apply appName clean up
cdcabrera added a commit that referenced this pull request Aug 17, 2020
* locale, i18n, appName, product context strings
* openshiftView, rhelView, apply appName, product context
* pageHeader, appName param, product context
* table, apply appName clean up
cdcabrera added a commit that referenced this pull request Aug 24, 2020
* locale, i18n, appName, product context strings
* openshiftView, rhelView, apply appName, product context
* pageHeader, appName param, product context
* table, apply appName clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants