Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory list needs to reset offset when paging limit increased #400

Closed
cdcabrera opened this issue Aug 28, 2020 · 8 comments
Closed

Inventory list needs to reset offset when paging limit increased #400

cdcabrera opened this issue Aug 28, 2020 · 8 comments
Assignees
Labels
bug Something isn't working env:dev phase 4

Comments

@cdcabrera
Copy link
Member

cdcabrera commented Aug 28, 2020

Description

Appears to be a bug, the offset/page doesn't reset when the paging limit is increased. this can lead to an API 4XX level error

Expected behavior

The GUI shouldn't break when increasing the paging limit.

Steps to reproduce

  1. Locate an account with over 10 inventory listings
  2. navigate to the 2nd offset/page with the paging controls
  3. select to increase the paging display limit
  4. error should be throw and the GUI displays an error state

Additional context, version info

Screen Shot 2020-08-28 at 1 30 38 PM

@cdcabrera cdcabrera added bug Something isn't working env:dev phase 4 labels Aug 28, 2020
@cdcabrera cdcabrera self-assigned this Aug 28, 2020
@ntkathole
Copy link
Member

Good catch @cdcabrera

@cdcabrera
Copy link
Member Author

@ntkathole if you could also confirm this has been resolved before we close this one down, that would be awesome!

@ntkathole
Copy link
Member

@cdcabrera This is still an issue. We should also reset offset when new filter applied. Here are steps:

  1. Have 100+ RHEL hosts and out of which only around 20 are "premium".
  2. Navigate to RHEL page.
  3. Navigate to last page of system table.
  4. Select SLA filter "Premium".

@cdcabrera
Copy link
Member Author

@ntkathole updates around reseting the paging when manipulating filters should be in CI-beta when you're available to confirm

@ntkathole
Copy link
Member

@cdcabrera There is still issue for openshift cores/socket filter. Here are steps:

  1. Have openshift clusters based on sockets less than openshift clusters based on cores.
  2. Navigate to openshift page.
  3. Navigate to last page of system table.
  4. Select "sockets" in filter.

@cdcabrera
Copy link
Member Author

Looks like we need a better way of handling this, investigating something a little bit more centralized so when we add additional filters we don't need to update multiple locations of paging resets.

@cdcabrera
Copy link
Member Author

cdcabrera commented Sep 9, 2020

Third round for the win, I hope =)

@ntkathole updates around reseting the paging when manipulating filters should be in CI-beta when you're available to confirm

We'll be squashing the last 3 #400 bug fix commits down into a single commit after confirmation, and doing the same for the #383 commits so we can track them a bit easier

@ntkathole
Copy link
Member

@cdcabrera Issue is fixed now. Thank you 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working env:dev phase 4
Projects
None yet
Development

No branches or pull requests

2 participants