Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move OptIn admin and Docs links into dotenv #416

Closed
3 tasks done
cdcabrera opened this issue Sep 10, 2020 · 0 comments
Closed
3 tasks done

Move OptIn admin and Docs links into dotenv #416

cdcabrera opened this issue Sep 10, 2020 · 0 comments
Assignees
@cdcabrera
Labels
phase 5 tech debt We've ignored it this long...

Comments

@cdcabrera
Copy link
Member

cdcabrera commented Sep 10, 2020 •
edited
Loading

Description

As a developer I need to relocate the links we have into the main dotenv file.

Acceptance Criteria

  • Optin https://access... link is in ./.env
  • PageHeader https://access... link is in ./.env
  • Dotenv params are funneled through src/common/helpers.js

Assumptions and Questions

  • partially based on conversations regarding a storage mechanism for external links
  • dotenv params need to use the prefix REACT_APP_
  • consider using a grouping prefix along with a one word description for param names i.e. REACT_APP_UI_LINK_DOCS
  • Before merging this one we need to confirm that CCS/docs isn't going to actively need to update their documentation link based on the GUI's display of system inventory - 09-15-2020 @jlprevatt
@cdcabrera cdcabrera added backlog Future work phase 5 tech debt We've ignored it this long... labels Sep 10, 2020
@cdcabrera cdcabrera assigned zanewoodfin and unassigned zanewoodfin Sep 15, 2020
@cdcabrera cdcabrera self-assigned this Sep 24, 2020
@cdcabrera cdcabrera removed the backlog Future work label Sep 24, 2020
@cdcabrera cdcabrera mentioned this issue Sep 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdcabrera cdcabrera

Labels
phase 5 tech debt We've ignored it this long...
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zanewoodfin @cdcabrera