Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): issues/437 update dotenv learn more link #438

Merged
merged 2 commits into from
Sep 26, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Sep 26, 2020

What's included

  • fix(docs): issues/437 update dotenv learn more link
  • fix(helpers): issues/416 move links to dotenv

    • helpers, expose dotenv links
    • optinView, move contact us link to dotenv
    • pageHeader, move learn more link to dotenv

Notes

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. Click on the subtitle "learn more" link

Example

Screen Shot 2020-09-25 at 8 00 05 PM

Updates issue/story

Closes #437 #416

* helpers, expose dotenv links
* optinView, move contact us link to dotenv
* pageHeader, move learn more link to dotenv
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2020

Codecov Report

Merging #438 into qa will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               qa     #438   +/-   ##
=======================================
  Coverage   92.71%   92.72%           
=======================================
  Files          69       69           
  Lines        1716     1718    +2     
  Branches      392      392           
=======================================
+ Hits         1591     1593    +2     
  Misses        110      110           
  Partials       15       15           
Impacted Files Coverage Δ
src/components/optinView/optinView.js 95.45% <ø> (ø)
src/components/pageLayout/pageHeader.js 100.00% <ø> (ø)
src/common/helpers.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa546b3...f4e39a6. Read the comment docs.

@cdcabrera cdcabrera merged commit a4df3fd into RedHatInsights:qa Sep 26, 2020
cdcabrera added a commit that referenced this pull request Sep 26, 2020
* helpers, expose dotenv links
* optinView, move contact us link to dotenv
* pageHeader, move learn more link to dotenv
cdcabrera added a commit that referenced this pull request Sep 26, 2020
* helpers, expose dotenv links
* optinView, move contact us link to dotenv
* pageHeader, move learn more link to dotenv
cdcabrera added a commit that referenced this pull request Sep 28, 2020
* helpers, expose dotenv links
* optinView, move contact us link to dotenv
* pageHeader, move learn more link to dotenv
cdcabrera added a commit that referenced this pull request Sep 29, 2020
* helpers, expose dotenv links
* optinView, move contact us link to dotenv
* pageHeader, move learn more link to dotenv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants