Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inventoryList): issues/442 activate last seen tooltip #445

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

cdcabrera
Copy link
Member

What's included

  • feat(inventoryList): issues/442 activate last seen tooltip
    • openshiftView, rhelView, activate platform last seen tooltip
    • inventoryListSelectors, guestListSelectors, apply date object

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. hover over the inventory "last seen" date, a tooltip should appear
  5. hover over the inventory "guests" "last seen" date, and a tooltip should appear, per design

Example

Screen Shot 2020-10-01 at 11 17 19 AM
Screen Shot 2020-10-01 at 10 54 25 AM (2)

Updates issue/story

#442

* openshiftView, rhelView, activate platform last seen tooltip
* inventoryListSelectors, guestListSelectors, apply date object
@codecov-commenter
Copy link

Codecov Report

Merging #445 into ci will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #445      +/-   ##
==========================================
+ Coverage   92.87%   92.88%   +0.01%     
==========================================
  Files          70       70              
  Lines        2174     2178       +4     
  Branches      696      700       +4     
==========================================
+ Hits         2019     2023       +4     
  Misses        138      138              
  Partials       17       17              
Impacted Files Coverage Δ
src/components/openshiftView/openshiftView.js 96.29% <100.00%> (+0.14%) ⬆️
src/components/rhelView/rhelView.js 93.54% <100.00%> (+0.44%) ⬆️
src/redux/selectors/guestsListSelectors.js 100.00% <100.00%> (ø)
src/redux/selectors/inventoryListSelectors.js 97.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9346d62...fc4ff02. Read the comment docs.

@cdcabrera cdcabrera merged commit beb77f5 into RedHatInsights:ci Oct 1, 2020
cdcabrera added a commit that referenced this pull request Oct 8, 2020
* openshiftView, rhelView, activate platform last seen tooltip
* inventoryListSelectors, guestListSelectors, apply date object
cdcabrera added a commit that referenced this pull request Oct 14, 2020
* openshiftView, rhelView, activate platform last seen tooltip
* inventoryListSelectors, guestListSelectors, apply date object
cdcabrera added a commit that referenced this pull request Oct 26, 2020
* openshiftView, rhelView, activate platform last seen tooltip
* inventoryListSelectors, guestListSelectors, apply date object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants