Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment Sync, Dev to Test #443

Merged
merged 16 commits into from
Oct 8, 2020
Merged

Environment Sync, Dev to Test #443

merged 16 commits into from
Oct 8, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Sep 30, 2020 •
edited
Loading

Description

Environment sync

Commits

Features

  1. inventoryList issues/410 activate column sorting (feat(inventoryList): issues/410 activate column sorting #433) (c367ebb)
  2. minHeight issues/403 set min-height, avoid page jumps (fix(inventoryList,graphCard): issues/403 set minheight on update #439) (26f097d)
  3. inventoryList issues/442 activate last seen tooltip (feat(inventoryList): issues/442 activate last seen tooltip #445) (beb77f5)

Bug Fixes

  1. build npm updates (fix(build): npm updates #420) (10a8447)
  2. testing activate GitHub workflow for commits (fix(testing): activate GitHub workflow for commits #432) (1dc8e77)
  3. openshiftView,rhelView issues/410 update sort default (fix(openshiftView,rhelView): issues/410 update sort default #444) (107e42a)
  4. inventoryList,graphCard issues/403 set minheight on update (fix(inventoryList,graphCard): issues/403 set minheight on update #439) (9346d62)
  5. inventoryList issues/403 minHeight update on perpage (fix(inventoryList): issues/403 minHeight update on perpage #447) (a0ec76b)
  6. minHeight issues/403 resize events reset height (fix(inventoryList): issues/403 minHeight update on perpage #447) (7d2d36a)
  7. inventoryList activate paging for smaller screen sizes (fix(inventoryList): issues/403 minHeight update on perpage #447) (f400527)
  8. chartArea resize observer test addition (fix(inventoryList): issues/403 minHeight update on perpage #447) (a86bdc2)

Chores

  1. docs issues/418 PR template review notes (chore(build): issues/418 PR template review notes #424) (9de02d0)
  2. docs issues/406 spandx config notes (chore(docs): issues/406 spandx config notes #425) (1cd091c)
  3. build npm update for react scripts (chore(build): npm update for react scripts #426) (4e2c11d)
  4. build activate GitHub workflow for PRs (chore(build): activate GitHub workflow for PRs #427) (eb46fc4)

Performance Improvements

  1. graphCardSelectors expand query filters for graph (feat(inventoryList): issues/410 activate column sorting #433) (1bac533)

Notes

  • Minor improvements to inventory display
  • Merging before RBAC inventory updates are merged into CI
  • @jlprevatt @ntkathole

@cdcabrera
fix(build): npm updates (#420)
10a8447 
* linting config, chartArea, rhsmServices, jsdoc formating
* testing, router, platform component check test expanded
@cdcabrera
chore(docs): issues/418 PR template review notes (#424)
9de02d0
@cdcabrera
chore(docs): issues/406 spandx config notes (#425)
1cd091c
@cdcabrera
chore(build): npm update for react scripts (#426)
4e2c11d
@cdcabrera
chore(build): activate GitHub workflow for PRs (#427)
eb46fc4 
* pull_request, GitHub workflow, error annotations, cache
* custom_release, Travis expand branches allowed for prod-stable
@cdcabrera
fix(testing): activate GitHub workflow for commits (#432)
1dc8e77 
* commit_lint, GitHub pull request workflow
* commit.test, actions.commit, move original check
@cdcabrera
perf(graphCardSelectors): expand query filters for graph (#433)
1bac533 
* graphCardSelectors, apply a state query filter
* inventoryListSelectors, remove related query ToDo
* openshfitView, rhelView, graphQuery rename for consistency
@cdcabrera
feat(inventoryList): issues/410 activate column sorting (#433)
c367ebb 
* inventoryList, apply onColumnSort callback
* inventoryListHelpers, expand isSortable filter for table component
* openshiftView, apply isSortable, clear inventory query
* rhelView, apply isSortable, clear inventory query
* table, expand sorting, active column, direction
* toolbar, clear inventory query
* viewReducer, queryTypes, clear inventory query
* rhsmApiTypes, sort, direction types
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020 •
edited
Loading

Codecov Report

Merging #443 into qa will increase coverage by 0.15%.
The diff coverage is 90.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##               qa     #443      +/-   ##
==========================================
+ Coverage   92.72%   92.88%   +0.15%     
==========================================
  Files          69       70       +1     
  Lines        1718     2178     +460     
  Branches      392      700     +308     
==========================================
+ Hits         1593     2023     +430     
- Misses        110      138      +28     
- Partials       15       17       +2
Impacted Files Coverage Δ
src/components/chartArea/chartArea.js 88.29% <ø> (+0.51%) ⬆️
src/components/toolbar/toolbar.js 97.01% <ø> (+0.46%) ⬆️
src/redux/actions/platformActions.js 100.00% <ø> (ø)
src/services/rhsmServices.js 100.00% <ø> (ø)
src/components/table/table.js 88.37% <80.64%> (+0.61%) ⬆️
src/components/inventoryList/inventoryList.js 90.90% <85.71%> (+1.25%) ⬆️
src/redux/reducers/viewReducer.js 96.96% <88.88%> (+2.85%) ⬆️
...c/components/inventoryList/inventoryListHelpers.js 94.44% <90.62%> (-5.56%) ⬇️
src/components/graphCard/graphCard.js 86.66% <100.00%> (+2.35%) ⬆️
src/components/minHeight/minHeight.js 100.00% <100.00%> (ø)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5241fcd...beb77f5. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Oct 7, 2020 •
edited
Loading

Codecov Report

Merging #443 into qa will increase coverage by 0.32%.
The diff coverage is 91.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##               qa     #443      +/-   ##
==========================================
+ Coverage   92.72%   93.04%   +0.32%     
==========================================
  Files          69       70       +1     
  Lines        1718     2201     +483     
  Branches      392      705     +313     
==========================================
+ Hits         1593     2048     +455     
- Misses        110      136      +26     
- Partials       15       17       +2
Impacted Files Coverage Δ
src/components/chartArea/chartArea.js 89.75% <ø> (+1.97%) ⬆️
src/components/toolbar/toolbar.js 97.01% <ø> (+0.46%) ⬆️
src/redux/actions/platformActions.js 100.00% <ø> (ø)
src/services/rhsmServices.js 100.00% <ø> (ø)
src/components/table/table.js 88.37% <80.64%> (+0.61%) ⬆️
src/components/inventoryList/inventoryList.js 90.90% <85.71%> (+1.25%) ⬆️
src/redux/reducers/viewReducer.js 96.96% <88.88%> (+2.85%) ⬆️
...c/components/inventoryList/inventoryListHelpers.js 94.44% <90.62%> (-5.56%) ⬇️
src/components/minHeight/minHeight.js 97.77% <97.77%> (ø)
src/components/graphCard/graphCard.js 86.66% <100.00%> (+2.35%) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5241fcd...a86bdc2. Read the comment docs.

@cdcabrera cdcabrera marked this pull request as ready for review October 8, 2020 02:04
@cdcabrera cdcabrera merged commit 0df7642 into qa Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdcabrera @codecov-commenter @codecov-io