Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hypervisor should display as "hypervisor" or "virtual" infrastructure type in system table #468

Closed
ntkathole opened this issue Oct 21, 2020 · 8 comments
Assignees
Labels
bug Something isn't working env:dev phase 5

Comments

@ntkathole
Copy link
Member

Description

We consider tally of hypervisor in virtual bucket but system table shows physical . (Previously we used to show as Hypervisor)

Reproducible only in CI-Beta.

Expected behavior

Hypervisor should show as "hypervisor" or "virtual" not physical.

Steps to reproduce

  1. Have hypervisor in account
  2. See system table

Additional context, version info

Screenshot from 2020-10-21 18-49-03

Screenshot from 2020-10-21 19-06-00

@ntkathole ntkathole added the bug Something isn't working label Oct 21, 2020
@cdcabrera cdcabrera self-assigned this Oct 21, 2020
@rblackbu
Copy link

Hey Nikhil, we are taking a look at this now and will post a direction by the end of the day. Thanks!

@cdcabrera
Copy link
Member

As discussed and indicated by UX/UI, specifically regarding the "hypervisor" display

  1. If it's a hypervisor, it’ll have a "chevron twistie" and a number of VMs bubble

And there are additional updates around the display meant to align to the graph and associated tooltips

  1. the inventory column formally called "Infrastructure" is now called "Type
  2. the guests inventory column formally called "Name" is now called "VM name"

@cdcabrera
Copy link
Member

cdcabrera commented Oct 28, 2020

Updated discussion with UX/UI and API, as an agreed upon iterative "next steps" the GUI will be

  1. Updated to use the Measurement Type column from the API
    • The API will review replacing the Cloud Providers currently in the response to simply be "CLOUD"
    • The API will review replacing the Hypervisor currently in the response with the word "VIRTUAL(IZED)"*
    • The GUI will display the word "Hypervisor" from the API response until the API is updated with "VIRTUAL(IZED)"*
    • The GUI will attempt to temporarily replace the Cloud Providers coming through in the response with the phrase "Public Cloud"... we may simply pass the data for display
  2. The acronym "VM" will be replaced in two locations to say "Guests [TOTAL]" and "Guest name" similar/same to the "pre" VM display
  3. The GUI will hold on displaying the column header change "Subscribed sockets"

@bclarhk @rblackbu @jlprevatt @kahowell

* note: Virtual vs Virtualized, alignment on the response should be considered

@bclarhk
Copy link

bclarhk commented Oct 28, 2020

This looks like a good iterative path forward.

@cdcabrera
Copy link
Member

cdcabrera commented Oct 28, 2020

Per the requested updates, see PR #485

Primary gotcha is lack of sorting on "measurement type"
Screen Shot 2020-10-28 at 2 11 51 PM

Possible solution

  • Since all table columns in a row have access to all the data for said row... we leave it as hardware type for sorting and simply display measurement type. However, this may relate an unexpected or confusing UX given Cloud Providers and Hypervisor are being passed back to the GUI... visual ≠ data

Screen Shot 2020-10-28 at 2 11 11 PM

@bclarhk
Copy link

bclarhk commented Oct 28, 2020

That sounds like "bad things could happen." We need to have [ measurement_type ] added to HostReportSort.

@cdcabrera
Copy link
Member

@ntkathole this appears to be resolved, short of any new issues that may be appearing, correct?

@ntkathole
Copy link
Member Author

Yes, it is resolved. We can close this! Currently we are showing it as Virtual. In future, we may reintroduce "Hypervisor" as a part of https://issues.redhat.com/browse/ENT-3210, which we need to track as separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working env:dev phase 5
Projects
None yet
Development

No branches or pull requests

4 participants