fix(inventoryList): issues/468 display measurementType #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* inventoryList, guestsList, expand prop types, content check * inventoryListSelectors, lowercase measurementType * locale, measurementType strings, VM to guests * openshiftView, rhelView, hardware to measurementType * rhsmApiTypes, add type, expected measurementType * rhsmServices, measurementType mock
Codecov Report
@@ Coverage Diff @@
## ci #485 +/- ##
==========================================
- Coverage 93.23% 93.08% -0.16%
==========================================
Files 70 70
Lines 1863 2270 +407
Branches 446 761 +315
==========================================
+ Hits 1737 2113 +376
- Misses 108 139 +31
Partials 18 18
Continue to review full report at Codecov.
|
cdcabrera
added a commit
that referenced
this pull request
Oct 28, 2020
* inventoryList, guestsList, expand prop types, content check * inventoryListSelectors, lowercase measurementType * locale, measurementType strings, VM to guests * openshiftView, rhelView, hardware to measurementType * rhsmApiTypes, add type, expected measurementType * rhsmServices, measurementType mock
cdcabrera
added a commit
that referenced
this pull request
Oct 29, 2020
* inventoryList, guestsList, expand prop types, content check * inventoryListSelectors, lowercase measurementType * locale, measurementType strings, VM to guests * openshiftView, rhelView, hardware to measurementType * rhsmApiTypes, add type, expected measurementType * rhsmServices, measurementType mock
cdcabrera
added a commit
that referenced
this pull request
Dec 2, 2020
* inventoryList, guestsList, expand prop types, content check * inventoryListSelectors, lowercase measurementType * locale, measurementType strings, VM to guests * openshiftView, rhelView, hardware to measurementType * rhsmApiTypes, add type, expected measurementType * rhsmServices, measurementType mock
cdcabrera
added a commit
that referenced
this pull request
Dec 2, 2020
* inventoryList, guestsList, expand prop types, content check * inventoryListSelectors, lowercase measurementType * locale, measurementType strings, VM to guests * openshiftView, rhelView, hardware to measurementType * rhsmApiTypes, add type, expected measurementType * rhsmServices, measurementType mock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
How to test
Proxy run check
$ yarn$ yarn start:proxyExample
Updates issue/story
updates #468