Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max character validation for display name filter search box #569

Closed
ntkathole opened this issue Feb 1, 2021 · 3 comments
Closed

Add max character validation for display name filter search box #569

ntkathole opened this issue Feb 1, 2021 · 3 comments
Assignees
Labels
api API response integration bug Something isn't working env:stage

Comments

@ntkathole
Copy link
Member

Description

As there is no limit on adding content to search box, user can enter any number characters which leads to 400 request on host list.

There is no adverse effect as application works fine after page refresh.

Expected behavior

Limitation of characters on user input.

Steps to reproduce

  1. Navigate to subscription watch.
  2. Add around 3k English characters in search box of filtering name.

Additional context, version info

Screenshot from 2021-02-01 15-27-16

@ntkathole ntkathole added the bug Something isn't working label Feb 1, 2021
@cdcabrera
Copy link
Member

cdcabrera commented Feb 1, 2021

So this probably needs to be a 2 part correction, GUI and API.

GUI can place a cap, but said limit can be bypassed. Is there an average name size that would be helpful @ntkathole ? Otherwise we'll just aim for 50 characters

@cdcabrera cdcabrera added api API response integration env:stage labels Feb 1, 2021
@cdcabrera cdcabrera self-assigned this Feb 1, 2021
@ntkathole
Copy link
Member Author

ntkathole commented Feb 1, 2021

So this probably needs to be a 2 part correction, GUI and API.

@kahowell can help us here in terms of api if having limit will help or the request will be rejected from other service before our validation.

GUI can place a cap, but said limit can be bypassed. Is there an average name size that would be helpful @ntkathole ?

I vote for 255 characters (https://access.redhat.com/solutions/2412), that's also for satellite 6/foreman team use, but I think that's topic for grooming or platform people.

@ntkathole
Copy link
Member Author

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API response integration bug Something isn't working env:stage
Projects
None yet
Development

No branches or pull requests

2 participants