Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolbarFieldDisplayName): issues/569 maxlength char limit #570

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(toolbarFieldDisplayName): issues/569 maxlength char limit
  • fix(reduxHelpers): response message status range

    • reduxHelpers, avoid caching large responses on emulated 304

Notes

  • applies a 255 maxlength character attribute to display name
    • appears that parts of the platform name search also need to have this limit implemented, environment checked, ci
    • Currently there is no design associated with "field validation" on the toolbar beyond toast notifications, @bclarhk @rblackbu

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. login, navigate to Subs Watch, attempt to enter beyond 255 characters into the display name field. The field will automatically truncate the number of characters entered

Example

...

Updates issue/story

#569

@cdcabrera cdcabrera merged commit aa285e3 into RedHatInsights:qa Feb 1, 2021
cdcabrera added a commit that referenced this pull request Feb 1, 2021
* reduxHelpers, avoid caching large responses on emulated 304
cdcabrera added a commit that referenced this pull request Feb 1, 2021
* reduxHelpers, avoid caching large responses on emulated 304
cdcabrera added a commit that referenced this pull request Feb 1, 2021
* reduxHelpers, avoid caching large responses on emulated 304
cdcabrera added a commit that referenced this pull request Feb 16, 2021
* reduxHelpers, avoid caching large responses on emulated 304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant