Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(productViewMissing): relax proptypes #649

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(productViewMissing): relax proptypes

Notes

  • also corrects a minor box shadow issue

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the box shadow does NOT display below the product cards

Example

before, box shadow

Screen Shot 2021-04-28 at 5 21 53 PM

Updates issue/story

Relates #630

@cdcabrera cdcabrera added 202104 project phase platform Contains, or is, platform specific work and issues labels Apr 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #649 (ca4506d) into ci (cf49ba0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #649   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files          87       87           
  Lines        2641     2641           
  Branches      924      924           
=======================================
  Hits         2477     2477           
  Misses        141      141           
  Partials       23       23           
Impacted Files Coverage Δ
src/components/productView/productViewMissing.js 95.23% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf49ba0...ca4506d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202104 project phase platform Contains, or is, platform specific work and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants