feat(productViewMissing): ent-3753 missing product view #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
added
202104
cdcabrera
force-pushed
the
ci
branch
3 times, most recently
from
6cc546d to
a3a563c
Compare
cdcabrera
force-pushed
the
ci-fallback-view
branch
2 times, most recently
from
421f415 to
8660425
Compare
cdcabrera
force-pushed
the
ci-fallback-view
branch
from
8660425 to
dea72c9
Compare
cdcabrera
changed the title
cdcabrera
commented
Apr 28, 2021
* i18n, missing product view strings, product titles * pageLayout, allow additional classNames * routerConfig, fallback root route, add nav filter prop, isSearchable * routerHelpers, basePath, consistency with baseName * styling, add product view styling for missing view, clean up
cdcabrera
force-pushed
the
ci-fallback-view
branch
from
dea72c9 to
cf92e2f
Compare
This was referenced Apr 28, 2021
cdcabrera
added a commit
that referenced
this pull request
Apr 29, 2021
* i18n, missing product view strings, product titles * pageLayout, allow additional classNames * productViewMissing, display products and nav * routerConfig, fallback root route, add nav filter prop, isSearchable * routerHelpers, basePath, consistency with baseName * styling, add product view styling for missing view, clean up
cdcabrera
added a commit
that referenced
this pull request
May 12, 2021
* i18n, missing product view strings, product titles * pageLayout, allow additional classNames * productViewMissing, display products and nav * routerConfig, fallback root route, add nav filter prop, isSearchable * routerHelpers, basePath, consistency with baseName * styling, add product view styling for missing view, clean up
cdcabrera
added a commit
that referenced
this pull request
May 18, 2021
* i18n, missing product view strings, product titles * pageLayout, allow additional classNames * productViewMissing, display products and nav * routerConfig, fallback root route, add nav filter prop, isSearchable * routerHelpers, basePath, consistency with baseName * styling, add product view styling for missing view, clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
window.pathname/beta/insights/subscriptionsor/rhel/subscriptionsor/random-path/openshift/subscriptionswill attempt a match on each path/dir segment, ie. for.../beta/insights/subscriptionsthat would be "beta" and "insights",/rhel/subscriptionsthat would be "rhel"/random-path/openshift/subscriptionsthat would be "random-path" and "openshift"How to test
Proxy run check
$ yarn$ yarn start:proxy/beta/insights/subscriptionsor/beta/openshift/subscriptionsExample
Updates issue/story
Relates towards RHCLOUD-13632
Relates ent-3753