-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(dev,proxy,prod): ent-3643 chrome local run, proxy, build #753
Conversation
ac99709
to
4535502
Compare
Codecov Report
@@ Coverage Diff @@
## ci #753 +/- ##
==========================================
- Coverage 95.29% 95.21% -0.08%
==========================================
Files 100 101 +1
Lines 2824 2823 -1
Branches 1027 1024 -3
==========================================
- Hits 2691 2688 -3
- Misses 126 128 +2
Partials 7 7
Continue to review full report at Codecov.
|
4535502
to
c21556d
Compare
@cdcabrera I was able to run the application in chrome 2 mode using this changes in CSC: diff --git a/chrome/fed-modules.json b/chrome/fed-modules.json
index 5ffcd23..a3f4085 100644
--- a/chrome/fed-modules.json
+++ b/chrome/fed-modules.json
@@ -141,11 +141,7 @@
"id": "openshift",
"module": "./RootApp",
"routes": [
- "/openshift",
- {
- "pathname": "/openshift/subscriptions",
- "dynamic": false
- }
+ "/openshift"
]
}
]
@@ -272,24 +268,20 @@
]
},
"subscriptions": {
- "dynamic": false,
+ "manifestLocation": "/apps/subscriptions/fed-mods.json",
"modules": [
{
"id": "insights-subscriptions",
+ "module": "./RootApp",
"routes": [
- {
- "pathname": "/insights/subscriptions",
- "dynamic": false
- }
+ "/insights/subscriptions"
]
},
{
"id": "openshift-subscriptions",
+ "module": "./RootApp",
"routes": [
- {
- "pathname": "/openshift/subscriptions",
- "dynamic": false
- }
+ "/openshift/subscriptions"
]
}
]
Obviously, you also have to remove the |
…tInsights#753) * babel, moved to independent config from package * build, empty module, plugins for html, dotenv replace * cspell, ouia keyword added * docs, local run descriptions, debugging updated * dotenv, locale path, port, build branch * eslint, json extensions are now required * jest, adjust coverage based on fed mod file adds * public, index.html apply esi instead of dotenv params * scripts, remove original dev chrome, clean up post, proxy * spandx, proxy routing clean up * src, fed module file adds, component dev checks removed * tests, integration-like tests updated * webpack, dev, proxy, prod configs
c21556d
to
798d7ae
Compare
…tInsights#753) * babel, moved to independent config from package * build, empty module, plugins for html, dotenv replace * cspell, ouia keyword added * docs, local run descriptions, debugging updated * dotenv, locale path, port, build branch * eslint, json extensions are now required * jest, adjust coverage based on fed mod file adds * public, index.html apply esi instead of dotenv params * scripts, remove original dev chrome, clean up post, proxy * spandx, proxy routing clean up * src, fed module file adds, component dev checks removed * tests, integration-like tests updated * webpack, dev, proxy, prod configs
798d7ae
to
320db77
Compare
reopening as PR #756 |
* babel, moved to independent config from package * build, empty module, plugins for html, dotenv replace * cspell, ouia keyword added * docs, local run descriptions, debugging updated * dotenv, locale path, port, build branch * eslint, json extensions are now required * jest, adjust coverage based on fed mod file adds * public, index.html apply esi instead of dotenv params * scripts, remove original dev chrome, clean up post, proxy * spandx, proxy routing clean up * src, fed module file adds, component dev checks removed * tests, integration-like tests updated * webpack, dev, proxy, prod configs
* babel, moved to independent config from package * build, empty module, html plugins, dotenv replace, travis * cspell, ouia keyword added * docs, local run descriptions, debugging updated * dotenv, locale path, port, build branch * eslint, json extensions are now required * jest, adjust coverage based on fed mod file adds * public, index.html apply esi instead of dotenv params * scripts, remove original dev chrome, clean up post, proxy * spandx, proxy routing clean up * src, fed module file adds, component dev checks removed * tests, integration-like tests updated * webpack, dev, proxy, prod configs
* babel, moved to independent config from package * build, empty module, html plugins, dotenv replace, travis * cspell, ouia keyword added * docs, local run descriptions, debugging updated * dotenv, locale path, port, build branch * eslint, json extensions are now required * jest, adjust coverage based on fed mod file adds * public, index.html apply esi instead of dotenv params * scripts, remove original dev chrome, clean up post, proxy * spandx, proxy routing clean up * src, fed module file adds, component dev checks removed * tests, integration-like tests updated * webpack, dev, proxy, prod configs
* babel, moved to independent config from package * build, empty module, html plugins, dotenv replace, travis * cspell, ouia keyword added * docs, local run descriptions, debugging updated * dotenv, locale path, port, build branch * eslint, json extensions are now required * jest, adjust coverage based on fed mod file adds * public, index.html apply esi instead of dotenv params * scripts, remove original dev chrome, clean up post, proxy * spandx, proxy routing clean up * src, fed module file adds, component dev checks removed * tests, integration-like tests updated * webpack, dev, proxy, prod configs
* babel, moved to independent config from package * build, empty module, html plugins, dotenv replace, travis * cspell, ouia keyword added * docs, local run descriptions, debugging updated * dotenv, locale path, port, build branch * eslint, json extensions are now required * jest, adjust coverage based on fed mod file adds * public, index.html apply esi instead of dotenv params * scripts, remove original dev chrome, clean up post, proxy * spandx, proxy routing clean up * src, fed module file adds, component dev checks removed * tests, integration-like tests updated * webpack, dev, proxy, prod configs
* babel, moved to independent config from package * build, empty module, html plugins, dotenv replace, travis * cspell, ouia keyword added * docs, local run descriptions, debugging updated * dotenv, locale path, port, build branch * eslint, json extensions are now required * jest, adjust coverage based on fed mod file adds * public, index.html apply esi instead of dotenv params * scripts, remove original dev chrome, clean up post, proxy * spandx, proxy routing clean up * src, fed module file adds, component dev checks removed * tests, integration-like tests updated * webpack, dev, proxy, prod configs
* babel, moved to independent config from package * build, empty module, html plugins, dotenv replace, travis * cspell, ouia keyword added * docs, local run descriptions, debugging updated * dotenv, locale path, port, build branch * eslint, json extensions are now required * jest, adjust coverage based on fed mod file adds * public, index.html apply esi instead of dotenv params * scripts, remove original dev chrome, clean up post, proxy * spandx, proxy routing clean up * src, fed module file adds, component dev checks removed * tests, integration-like tests updated * webpack, dev, proxy, prod configs
* babel, moved to independent config from package * build, empty module, html plugins, dotenv replace, travis * cspell, ouia keyword added * docs, local run descriptions, debugging updated * dotenv, locale path, port, build branch * eslint, json extensions are now required * jest, adjust coverage based on fed mod file adds * public, index.html apply esi instead of dotenv params * scripts, remove original dev chrome, clean up post, proxy * spandx, proxy routing clean up * src, fed module file adds, component dev checks removed * tests, integration-like tests updated * webpack, dev, proxy, prod configs
* babel, moved to independent config from package * build, empty module, html plugins, dotenv replace, travis * cspell, ouia keyword added * docs, local run descriptions, debugging updated * dotenv, locale path, port, build branch * eslint, json extensions are now required * jest, adjust coverage based on fed mod file adds * public, index.html apply esi instead of dotenv params * scripts, remove original dev chrome, clean up post, proxy * spandx, proxy routing clean up * src, fed module file adds, component dev checks removed * tests, integration-like tests updated * webpack, dev, proxy, prod configs
What's included
Notes
Chrome 2
via theskipChrome2
flag for our two development webpack aspects, noted below in the PR review/comments.How to test
Coverage and basic unit test check
$ yarn
$ yarn test
Local run check
$ yarn
$ yarn start
.env.local
file in the root of the project and add the following paramsProxy run check
$ yarn
$ yarn start:proxy
Check the build
$ yarn
$ yarn build
Example
...
Updates issue/story
ent-3643
ent-3642