Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REOPEN #753 build(dev,proxy,prod): ent-3643 chrome local run, proxy, build #756

Merged
merged 3 commits into from
Aug 3, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jul 30, 2021

reopen PR #753 build(dev,proxy,prod): ent-3643 chrome local run, proxy, build

Notes

Few aspects to this "reopen"

  1. First we had to double check the Travis CI aspect of the build... appears we def needed to add a change/update for the correct build output directory... build -> dist so Travis knows where to go.
    • The last 2 commits on this PR will be squashed together, Travis and the dev,proxy,prod updates
  2. Second we need to have the platform config updates merged in order for the Chrome 2 aspect of the updates to function correctly... basically we need another PR here for Chrome 2 on Subs, [ci-beta] Enable chrome2 for subscriptions cloud-services-config#841
  3. And third, we didn't want to cause issues bright and early Monday morning @mirekdlugosz =)

…tInsights#753)

* babel, moved to independent config from package
* build, empty module, plugins for html, dotenv replace
* cspell, ouia keyword added
* docs, local run descriptions, debugging updated
* dotenv, locale path, port, build branch
* eslint, json extensions are now required
* jest, adjust coverage based on fed mod file adds
* public, index.html apply esi instead of dotenv params
* scripts, remove original dev chrome, clean up post, proxy
* spandx, proxy routing clean up
* src, fed module file adds, component dev checks removed
* tests, integration-like tests updated
* webpack, dev, proxy, prod configs
@codecov-commenter
Copy link

Codecov Report

Merging #756 (cbe5391) into ci (4126a4f) will decrease coverage by 0.07%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #756      +/-   ##
==========================================
- Coverage   95.29%   95.21%   -0.08%     
==========================================
  Files         100      101       +1     
  Lines        2824     2823       -1     
  Branches     1027     1024       -3     
==========================================
- Hits         2691     2688       -3     
- Misses        126      128       +2     
  Partials        7        7              
Impacted Files Coverage Δ
src/AppEntry.js 0.00% <0.00%> (ø)
src/config/index.js 100.00% <ø> (ø)
src/components/authentication/authentication.js 73.17% <62.50%> (-0.64%) ⬇️
src/components/router/routerHelpers.js 100.00% <100.00%> (ø)
src/hooks/useRouter.js 100.00% <100.00%> (ø)
src/services/platformServices.js 97.61% <100.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4126a4f...cbe5391. Read the comment docs.

@cdcabrera cdcabrera added 202108 project phase story New feature, or process work tech debt We've ignored it this long... labels Jul 30, 2021
@cdcabrera cdcabrera merged commit e0e208d into RedHatInsights:ci Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202108 project phase story New feature, or process work tech debt We've ignored it this long...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants