fix(graphCardHelpers): sw-235 generateChartId threshold

[cdcabrera]

What's included

• fix(graphCardHelpers): sw-235 generateChartId threshold

Notes

• minimal visual differences for legend tooltips on RHEL and OpenShift Container Platform

• resolves a future issue where duplicate metric IDs can be used for both Tally and Capacity by adding the isCapacity/isThreshold ID

  • This may also have allow us to store both Tally and Capacity results under the same parent state via Redux

• we have an awkward situation where the deprecated graph component used by RHEL, and OpenShift (Container, Metric/On-Demand, Dedicated) product displays makes use of a common graph legend component that's being updated towards using a generated ID. That generated ID takes into account...

  • product id
  • category
  • isCapacity/isThreshold
  • metric id

  ... but creates a copy regression scenario for the aforementioned product displays. The products still display strings, just not the ones tailored for them specifically, the context fallback strings, because the deprecated graph component doesn't pass the required IDs to generate the unique legend ID used by the copy tooling.

  We could try to fix the deprecated component, but it is deprecated for a reason, and we are following this PR up with a subsequent PR that moves RHEL, OpenShift et all, and Satellite over to the new graph. Which means that effort would immediately be unused.

  We'll make sure to note the related PR, and merge sequentially @mirekdlugosz
  - subsequent PR refactor(config): sw-690 rhel, satellite, openshift metric graph #1002

How to test

Coverage and basic unit test check

1. update the NPM packages with $ yarn
2. $ yarn test
3. confirm tests come back clean

Local run check

1. update the NPM packages with $ yarn
2. $ yarn start
3. confirm that existing On-Demand display tooltips behave as intended

Example

...

Updates issue/story

sw-235
related sw-690
partially fixes sw-689
expands #1000