Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): sw-860 inventory to instance id #1050

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Feb 7, 2023

What's included

  • refactor(config): sw-860 inventory to instance id

Notes

  • flips RHEL, and existing products from the old inventory_id to instance_id
  • the GUI will not throw an error if instance_id or inventory_id is missing... the link will remain hidden

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. log in with the appropriate account and confirm
    • that links are display in the name instances displays for RHEL, RHOSAK/streams, RHODS, and RHACS if there is an instance_id available in the response and the user is authorized

Example

Screen Shot 2023-02-13 at 4 32 23 PM

Updates issue/story

sw-860
sw-870
relates sw-235

@cdcabrera cdcabrera added 202304 project phase hold labels Feb 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1050 (72c9aa3) into dev (a8e3c9f) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1050   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files         122      122           
  Lines        4071     4071           
  Branches     1662     1662           
=======================================
  Hits         3809     3809           
  Misses        245      245           
  Partials       17       17           
Impacted Files Coverage Δ
src/services/rhsm/rhsmConstants.js 100.00% <ø> (ø)
src/services/rhsm/rhsmSchemas.js 100.00% <ø> (ø)
src/services/rhsm/rhsmServices.js 100.00% <ø> (ø)
src/config/product.rhacs.js 85.71% <100.00%> (ø)
src/config/product.rhel.js 88.37% <100.00%> (ø)
src/config/product.rhods.js 85.71% <100.00%> (ø)
src/config/product.rhosak.js 83.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e3c9f...72c9aa3. Read the comment docs.

@cdcabrera cdcabrera marked this pull request as ready for review February 13, 2023 21:27
@cdcabrera cdcabrera removed the hold label Feb 15, 2023
* config, rhacs, rhel, rhods, rhosak, instance id
* services, replace inventory with instance id
@cdcabrera cdcabrera merged commit 17a1d45 into RedHatInsights:dev Feb 15, 2023
cdcabrera added a commit that referenced this pull request Feb 20, 2023
* config, rhacs, rhel, rhods, rhosak, instance id
* services, replace inventory with instance id
cdcabrera added a commit that referenced this pull request Mar 2, 2023
* config, rhacs, rhel, rhods, rhosak, instance id
* services, replace inventory with instance id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202304 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants