-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): ephemeral rename, nav items #1051
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #1051 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 123 123
Lines 4274 4274
Branches 1743 1743
=======================================
Hits 4002 4002
Misses 254 254
Partials 18 18 Continue to review full report in Codecov by Sentry.
|
@san7ket few pieces
|
Thanks, for the comments, I don't think it is urgent, I thought the merge job would run on main branch, but I see that's not the case. I have updated the branch to dev and will improve the commit message, also I would like to use this as a testing PR to play around with left nav in EE, if that's possible. I will also mark it as draft until I can figure out a way to make the ephemeral EE as close to stage as possible. |
f08f464
to
993cf5b
Compare
@san7ket that works for us! applied the "build:hold" label... if/when this is ready to go just give us/me a heads up |
/retest |
396dd2b
to
d50d5e6
Compare
@cdcabrera we can merge this, we now have a way to navigate to these left nav items |
@cdcabrera Any pointers as to why checks are failing |
0360145
to
4e98481
Compare
2bf3b1c
to
0321d53
Compare
@san7ket apologies we missed your note about merging. I can bring the PR up-to-date. Do you still want this merged? And can we shut the other PR with your name on it down? |
@san7ket we brought this PR up-to-date, however... about the pr failing, if curious
|
Apologies for delay, both the PR's related to the PRchecks are blocked due to the new navigation (Business --> Subscriptions)change that is implemented in the stage but the changes have not yet propagated to the frontend-operator (last time I checked ) for Ephemeral environments. The issue is being tracked at https://issues.redhat.com/browse/RHCLOUD-25569. I can recheck again this week if anything has changed in EE. Meanwhile, Would it make sense to hold this and 1072 PR. |
5ba4b01
to
e99bfe0
Compare
254610a
to
ff0a957
Compare
daf3415
to
fd9c077
Compare
/retest |
@cdcabrera Tested this with latest code, we can merge this, this is needed to nav inbetween pages RHEL to openshift and vice versa in ephemeral envs. |
@san7ket much appreciated on the heads up!
|
Looks like I need to double check something on the integration check before we merge... |
Ok, updating the left nav integration snapshot should do it. Once it passes the primary tests we'll squash it down into your original commit |
What's included
...
How to test
Example
...
Updates issue/story