Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): ephemeral rename, nav items #1051

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

san7ket
Copy link
Contributor

@san7ket san7ket commented Feb 8, 2023

What's included

...

How to test

Example

...

Updates issue/story

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Merging #1051 (9ef7419) into dev (07ed88c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1051   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files         123      123           
  Lines        4274     4274           
  Branches     1743     1743           
=======================================
  Hits         4002     4002           
  Misses        254      254           
  Partials       18       18           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ed88c...9ef7419. Read the comment docs.

@cdcabrera
Copy link
Member

cdcabrera commented Feb 8, 2023

@san7ket few pieces

  • commit message needs to be updated to reflect scope for tracking/changelog purposes, recommend something like
    • chore(build): rename, openshift container or chore(build): ephemeral rename, openshift or fix(build): ... if its an error fix. there's also a message length limit
  • next, dev/feature is being planned for merge into main next week. (merging into main at this time indicates a priority over the current work lined up for RHEL VDC)
    • As much as we enjoy rebasing feature work, is this rename a make/break type scenario?
    • Can this PR be redirected to point at dev instead?

@cdcabrera cdcabrera added build 202304 project phase labels Feb 8, 2023
@san7ket san7ket changed the base branch from main to dev February 9, 2023 06:42
@san7ket
Copy link
Contributor Author

san7ket commented Feb 9, 2023

@san7ket few pieces

  • commit message needs to be updated to reflect scope for tracking/changelog purposes, recommend something like

    • chore(build): rename, openshift container or chore(build): ephemeral rename, openshift or fix(build): ... if its an error fix. there's also a message length limit
  • next, dev/feature is being planned for merge into main next week. (merging into main at this time indicates a priority over the current work lined up for RHEL VDC)

    • As much as we enjoy rebasing feature work, is this rename a make/break type scenario?
    • Can this PR be redirected to point at dev instead?

Thanks, for the comments, I don't think it is urgent, I thought the merge job would run on main branch, but I see that's not the case. I have updated the branch to dev and will improve the commit message, also I would like to use this as a testing PR to play around with left nav in EE, if that's possible. I will also mark it as draft until I can figure out a way to make the ephemeral EE as close to stage as possible.

@san7ket san7ket changed the title Update Container Platform to reflect what we have in Stage chore(build): ephemeral rename, nav items Feb 9, 2023
@san7ket san7ket force-pushed the patch-1 branch 3 times, most recently from f08f464 to 993cf5b Compare February 9, 2023 14:19
@cdcabrera cdcabrera added the build:hold Not really blocked. Either updates were just released or local validation required label Feb 9, 2023
@cdcabrera
Copy link
Member

@san7ket that works for us! applied the "build:hold" label... if/when this is ready to go just give us/me a heads up

@san7ket
Copy link
Contributor Author

san7ket commented Feb 20, 2023

/retest

@san7ket
Copy link
Contributor Author

san7ket commented Apr 19, 2023

@cdcabrera we can merge this, we now have a way to navigate to these left nav items

@san7ket
Copy link
Contributor Author

san7ket commented Apr 20, 2023

@cdcabrera Any pointers as to why checks are failing

@ntkathole ntkathole requested a review from cdcabrera April 20, 2023 10:55
@san7ket san7ket force-pushed the patch-1 branch 2 times, most recently from 0360145 to 4e98481 Compare April 26, 2023 08:17
@cdcabrera cdcabrera force-pushed the dev branch 3 times, most recently from 2bf3b1c to 0321d53 Compare April 28, 2023 13:34
@cdcabrera
Copy link
Member

cdcabrera commented May 2, 2023

@san7ket apologies we missed your note about merging. I can bring the PR up-to-date.

Do you still want this merged? And can we shut the other PR with your name on it down?

@cdcabrera
Copy link
Member

@san7ket we brought this PR up-to-date, however...
RHEL and OpenShift are covered now in the stage-beta environment where this PR would merge first... we're assuming this can be shut down now?

about the pr failing, if curious

  • Looks like the GitHub CI cache was suffering from an outdated package failure... we just removed the cache files and restarted the job
  • Also, the dist output testing checks against the yaml menu file for coverage for existing product configs in the repo. That check/snapshot needs to be updated every time the yaml file is adjusted around the menu... (it also happens to be a little hidden in the process)
    1. update the NPM packages with $ yarn
    2. run $ yarn build to get the failure and available files
    3. next run $ yarn test:integration-dev follow the directions to update the file
    4. finally commit any changes with your PR

@san7ket
Copy link
Contributor Author

san7ket commented May 9, 2023

Apologies for delay, both the PR's related to the PRchecks are blocked due to the new navigation (Business --> Subscriptions)change that is implemented in the stage but the changes have not yet propagated to the frontend-operator (last time I checked ) for Ephemeral environments. The issue is being tracked at https://issues.redhat.com/browse/RHCLOUD-25569. I can recheck again this week if anything has changed in EE. Meanwhile, Would it make sense to hold this and 1072 PR.

@cdcabrera cdcabrera force-pushed the dev branch 3 times, most recently from 5ba4b01 to e99bfe0 Compare June 6, 2023 15:01
@cdcabrera cdcabrera added the 202308 project phase label Jul 7, 2023
@cdcabrera cdcabrera force-pushed the dev branch 2 times, most recently from 254610a to ff0a957 Compare July 24, 2023 21:01
@san7ket san7ket force-pushed the patch-1 branch 2 times, most recently from daf3415 to fd9c077 Compare August 11, 2023 08:12
@san7ket
Copy link
Contributor Author

san7ket commented Aug 14, 2023

/retest

@san7ket
Copy link
Contributor Author

san7ket commented Aug 14, 2023

@cdcabrera Tested this with latest code, we can merge this, this is needed to nav inbetween pages RHEL to openshift and vice versa in ephemeral envs.

@cdcabrera
Copy link
Member

cdcabrera commented Aug 15, 2023

@san7ket much appreciated on the heads up!

we'll go ahead and rebase this and get it merged today 20230815 spoke out of turn, see review

deploy/frontend.yaml Show resolved Hide resolved
@cdcabrera cdcabrera removed the build:hold Not really blocked. Either updates were just released or local validation required label Aug 15, 2023
cdcabrera
cdcabrera previously approved these changes Aug 22, 2023
@cdcabrera
Copy link
Member

Looks like I need to double check something on the integration check before we merge...

@cdcabrera
Copy link
Member

cdcabrera commented Aug 22, 2023

Ok, updating the left nav integration snapshot should do it. Once it passes the primary tests we'll squash it down into your original commit

@cdcabrera cdcabrera merged commit 0be2b2d into RedHatInsights:dev Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202304 project phase 202308 project phase build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants