Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(graphCard): sw-747, sw-748 styling, copy #1119

Merged
merged 1 commit into from
May 4, 2023
Merged

fix(graphCard): sw-747, sw-748 styling, copy #1119

merged 1 commit into from
May 4, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented May 4, 2023 •
edited
Loading

What's included

Notes

  • restores some of the previous styling associated with the cause of sw-1030 , specifically the padding used for the axes labels. To recap Victory Charts creates a skipping display for data points on the graph when a resize is applied on the SVG
  • adds a data-test=graphStandalone attribute around standalone graphs that do not use the metric left card display... OpenShift Container, OpenShift-metric, OpenShift-Dedicated-metric, RHEL, and Satellite.
  • adjust copy on OpenShift Container Platform towards Red Hat OpenShift to include all variants

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

Updates issue/story

sw-747 sw-748
related with sw-1030

@cdcabrera cdcabrera added the 202304 project phase label May 4, 2023
@cdcabrera
fix(graphCard): sw-747, sw-748 styling, copy
499daa9 
* locale, variant OpenShift strings
* graphCardHelpers, pad axes on label existence
* graphCardMetricTotals, div test wrapper for standalone
* styling, graph padding for standalone
@cdcabrera cdcabrera changed the title fix(graphCardMetricTotals): sw-747, sw-748 styling, copy fix(graphCard): sw-747, sw-748 styling, copy May 4, 2023
@cdcabrera cdcabrera marked this pull request as ready for review May 4, 2023 20:22
@cdcabrera cdcabrera merged commit dac494f into RedHatInsights:dev May 4, 2023
cdcabrera added a commit that referenced this pull request May 25, 2023
@cdcabrera
fix(graphCard): sw-747, sw-748 styling, copy (#1119)
ee403b6 
* locale, variant OpenShift strings
* graphCardHelpers, pad axes on label existence
* graphCardMetricTotals, div test wrapper for standalone
* styling, graph padding for standalone
@cdcabrera cdcabrera mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
202304 project phase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cdcabrera