Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): sw-747 OpenShift Dedicated and metrics on-demand displays #1120

Merged
merged 1 commit into from
May 9, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented May 5, 2023

What's included

  • refactor(config): sw-747 dedicated and metrics on-demand displays

Notes

  • includes a relax on the jest coverage for branch... it's been an ongoing issue where it's always just below our cut-off of 80% usually in the range of 0.10 to 0.03 below. This helps in time recovery against the level of effort to gain a fraction of coverage handled in separate PR

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. navigate towards the OpenShift variant display and confirm
    • copy correctly displays across OpenShift Dedicated and Metrics/On-Demand
    • the graphs display the correct metrics
    • the graph cards, to the left, correctly display daily and monthly values

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

Screenshot 2023-05-05 at 12-30-58 Standalone Curiosity
Screenshot 2023-05-05 at 12-39-19 Standalone Curiosity

Updates issue/story

sw-747

@cdcabrera cdcabrera added the 202304 project phase label May 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

Merging #1120 (492d453) into dev (dac494f) will increase coverage by 0.13%.
The diff coverage is 91.83%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1120      +/-   ##
==========================================
+ Coverage   93.61%   93.74%   +0.13%     
==========================================
  Files         122      122              
  Lines        4257     4286      +29     
  Branches     1735     1758      +23     
==========================================
+ Hits         3985     4018      +33     
+ Misses        254      250       -4     
  Partials       18       18              
Impacted Files Coverage Δ
src/config/product.openshiftMetrics.js 84.09% <90.00%> (+0.75%) ⬆️
src/config/product.openshiftDedicated.js 84.78% <90.47%> (+0.91%) ⬆️
src/config/product.rhacs.js 89.79% <100.00%> (+4.08%) ⬆️
src/config/product.rhods.js 89.79% <100.00%> (+4.08%) ⬆️
src/config/product.rhosak.js 91.22% <100.00%> (+7.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac494f...492d453. Read the comment docs.

@cdcabrera cdcabrera force-pushed the sw-747-dedicated branch from 492d453 to f019fb2 Compare May 5, 2023 16:52
* config, OpenShift dedicated and metrics on-demand
* config, rhacs, rhods, rhosak align func defaults
* locale, dedicated, metrics display
@cdcabrera cdcabrera force-pushed the sw-747-dedicated branch from f019fb2 to 79da48d Compare May 5, 2023 19:24
@cdcabrera cdcabrera added the hold label May 5, 2023
@cdcabrera
Copy link
Member Author

As of 20230505 waiting for integration test updates before merging

@cdcabrera cdcabrera merged commit 1e76f8e into RedHatInsights:dev May 9, 2023
cdcabrera added a commit that referenced this pull request May 25, 2023
)

* config, OpenShift dedicated and metrics on-demand
* config, rhacs, rhods, rhosak align callback defaults
* locale, dedicated, metrics display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202304 project phase hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants