Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 of 3 - build(babel): sw-1348 update presets, targets #1148

Merged
merged 1 commit into from
Jul 25, 2023
Merged

2 of 3 - build(babel): sw-1348 update presets, targets #1148

merged 1 commit into from
Jul 25, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jun 29, 2023 •
edited
Loading

What's included

  • build(babel): sw-1348 update presets, targets

Notes

  • Part 2 of 3

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm test come back clean

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm test come back clean

Example

...

Updates issue/story

sw-1348

related #1146 #1144

@cdcabrera cdcabrera added the 202308 project phase label Jun 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023 •
edited
Loading

Codecov Report

Merging #1148 (ad8604c) into dev (5082a88) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1148   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files         123      123           
  Lines        4364     4364           
  Branches     1799     1799           
=======================================
  Hits         4082     4082           
  Misses        262      262           
  Partials       20       20

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5082a88...ad8604c. Read the comment docs.

@cdcabrera cdcabrera mentioned this pull request Jun 29, 2023
Merged
@cdcabrera cdcabrera added the blocked Prevented from continuing label Jul 5, 2023
@cdcabrera cdcabrera changed the title build(babel): sw-1348 update presets, targets 2 of 3 - build(babel): sw-1348 update presets, targets Jul 17, 2023
@cdcabrera cdcabrera mentioned this pull request Jul 17, 2023
Merged
@cdcabrera cdcabrera force-pushed the dev branch 2 times, most recently from 254610a to ff0a957 Compare July 24, 2023 21:01
@cdcabrera cdcabrera removed the blocked Prevented from continuing label Jul 25, 2023
@cdcabrera cdcabrera marked this pull request as ready for review July 25, 2023 19:20
@cdcabrera cdcabrera changed the base branch from dev to main July 25, 2023 19:21
@cdcabrera
build(babel): sw-1348 update presets, targets
8737ea9 
* dotenv, fix setting params
* build, babel dist, testing presets, browser targets
* testing, eslint npm updates
@cdcabrera cdcabrera force-pushed the sw-1348-lint-test branch from ad8604c to 8737ea9 Compare July 25, 2023 19:32
@cdcabrera cdcabrera merged commit dd1af49 into RedHatInsights:main Jul 25, 2023
cdcabrera added a commit that referenced this pull request Aug 8, 2023
@cdcabrera
build(babel): sw-1348 update presets, targets (#1148)
9ccf31d 
* dotenv, fix setting params
* build, babel dist, testing presets, browser targets
* testing, eslint npm updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
202308 project phase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdcabrera @codecov-commenter