-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(table): sw-1537 migrate to pf composable table #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
added
patternfly
Patternfly UI/UX and implementation
202308
project phase
labels
Aug 17, 2023
cdcabrera
force-pushed
the
sw-1537
branch
2 times, most recently
from
August 23, 2023 12:12
77dbba6
to
a1f86e8
Compare
cdcabrera
force-pushed
the
sw-1537
branch
4 times, most recently
from
September 6, 2023 12:46
4194592
to
5037019
Compare
cdcabrera
force-pushed
the
sw-1537
branch
6 times, most recently
from
September 11, 2023 20:20
28651ea
to
5e36561
Compare
Codecov Report
@@ Coverage Diff @@
## main #1168 +/- ##
==========================================
+ Coverage 92.15% 92.44% +0.29%
==========================================
Files 121 123 +2
Lines 4205 4238 +33
Branches 1758 1771 +13
==========================================
+ Hits 3875 3918 +43
Misses 301 301
+ Partials 29 19 -10 Continue to review full report in Codecov by Sentry.
|
* config, product inventory formats * inventoryCard, convert towards standalone * inventoryCardInstances, instances context * inventoryCardSubscriptions, subs context * inventoryGuests, API transformer for infinite scroll * locale, string key formatting * productView, flip to inventoryCardInstances * table, refactor towards composable * useReactRedux, shallow to deep equality * rhsmServices, use guests, subs transformers
cdcabrera
added a commit
that referenced
this pull request
Sep 14, 2023
* config, product inventory formats * inventoryCard, convert towards standalone * inventoryCardInstances, instances context * inventoryCardSubscriptions, subs context * inventoryGuests, API transformer for infinite scroll * locale, string key formatting * productView, flip to inventoryCardInstances * table, refactor towards pf composable * useReactRedux, shallow to deep equality * rhsmServices, use guests, subs transformers
cdcabrera
added a commit
that referenced
this pull request
Sep 19, 2023
* config, product inventory formats * inventoryCard, convert towards standalone * inventoryCardInstances, instances context * inventoryCardSubscriptions, subs context * inventoryGuests, API transformer for infinite scroll * locale, string key formatting * productView, flip to inventoryCardInstances * table, refactor towards pf composable * useReactRedux, shallow to deep equality * rhsmServices, use guests, subs transformers
cdcabrera
added a commit
that referenced
this pull request
Sep 19, 2023
* config, product inventory formats * inventoryCard, convert towards standalone * inventoryCardInstances, instances context * inventoryCardSubscriptions, subs context * inventoryGuests, API transformer for infinite scroll * locale, string key formatting * productView, flip to inventoryCardInstances * table, refactor towards pf composable * useReactRedux, shallow to deep equality * rhsmServices, use guests, subs transformers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
How to test
Coverage and basic unit test check
$ yarn
$ yarn test
Proxy run check
$ yarn
$ yarn start:proxy
Check the build
$ yarn
$ yarn build
Example
...
Updates issue/story
sw-1537
related #1184 #1183 #1187