Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(table): sw-1537 migrate to pf composable table #1168

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Aug 17, 2023

What's included

  • refactor(table): sw-1537 migrate to pf composable table

Notes

  • prep for migrating to PF5
    • replaces deprecated table with composable table
  • minor spacing differences ONLY, behavior, to an end user, should have no apparent difference

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm ALL products display as intended for Instances, Subscriptions and Guests displays
    • display column header strings
    • display column values

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

...

Updates issue/story

sw-1537

related #1184 #1183 #1187

@cdcabrera cdcabrera added patternfly Patternfly UI/UX and implementation 202308 project phase labels Aug 17, 2023
@cdcabrera cdcabrera force-pushed the sw-1537 branch 2 times, most recently from 77dbba6 to a1f86e8 Compare August 23, 2023 12:12
@cdcabrera cdcabrera changed the base branch from dev to main August 29, 2023 17:09
@cdcabrera cdcabrera added the hold label Aug 29, 2023
@cdcabrera cdcabrera force-pushed the sw-1537 branch 4 times, most recently from 4194592 to 5037019 Compare September 6, 2023 12:46
@cdcabrera cdcabrera force-pushed the sw-1537 branch 6 times, most recently from 28651ea to 5e36561 Compare September 11, 2023 20:20
@cdcabrera cdcabrera marked this pull request as ready for review September 11, 2023 20:20
@cdcabrera cdcabrera removed the hold label Sep 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Merging #1168 (276caa3) into main (1d65fd8) will increase coverage by 0.29%.
The diff coverage is 84.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
+ Coverage   92.15%   92.44%   +0.29%     
==========================================
  Files         121      123       +2     
  Lines        4205     4238      +33     
  Branches     1758     1771      +13     
==========================================
+ Hits         3875     3918      +43     
  Misses        301      301              
+ Partials       29       19      -10     
Files Changed Coverage
src/components/productView/productView.js ø
...Subscriptions/inventoryCardSubscriptionsContext.js 26.92%
src/config/product.openshiftContainer.js 70.00%
src/config/product.rhel.js 75.00%
src/config/product.openshiftMetrics.js 78.57%
...toryCardInstances/inventoryCardInstancesContext.js 79.79%
src/config/product.openshiftDedicated.js 80.00%
src/config/product.satellite.js 80.00%
...c/components/inventoryCard/inventoryCardHelpers.js 81.66%
...mponents/inventoryGuests/inventoryGuestsContext.js 85.71%
... and 13 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d65fd8...276caa3. Read the comment docs.

* config, product inventory formats
* inventoryCard, convert towards standalone
* inventoryCardInstances, instances context
* inventoryCardSubscriptions, subs context
* inventoryGuests, API transformer for infinite scroll
* locale, string key formatting
* productView, flip to inventoryCardInstances
* table, refactor towards composable
* useReactRedux, shallow to deep equality
* rhsmServices, use guests, subs transformers
@cdcabrera cdcabrera merged commit dc9aa45 into RedHatInsights:main Sep 13, 2023
cdcabrera added a commit that referenced this pull request Sep 14, 2023
* config, product inventory formats
* inventoryCard, convert towards standalone
* inventoryCardInstances, instances context
* inventoryCardSubscriptions, subs context
* inventoryGuests, API transformer for infinite scroll
* locale, string key formatting
* productView, flip to inventoryCardInstances
* table, refactor towards pf composable
* useReactRedux, shallow to deep equality
* rhsmServices, use guests, subs transformers
cdcabrera added a commit that referenced this pull request Sep 19, 2023
* config, product inventory formats
* inventoryCard, convert towards standalone
* inventoryCardInstances, instances context
* inventoryCardSubscriptions, subs context
* inventoryGuests, API transformer for infinite scroll
* locale, string key formatting
* productView, flip to inventoryCardInstances
* table, refactor towards pf composable
* useReactRedux, shallow to deep equality
* rhsmServices, use guests, subs transformers
cdcabrera added a commit that referenced this pull request Sep 19, 2023
* config, product inventory formats
* inventoryCard, convert towards standalone
* inventoryCardInstances, instances context
* inventoryCardSubscriptions, subs context
* inventoryGuests, API transformer for infinite scroll
* locale, string key formatting
* productView, flip to inventoryCardInstances
* table, refactor towards pf composable
* useReactRedux, shallow to deep equality
* rhsmServices, use guests, subs transformers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202308 project phase patternfly Patternfly UI/UX and implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants