Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chartArea): issues/79 streamline on multiple data facets #122

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(chartArea): issues/79 streamline on multiple data facets
    • chartArea, allow multiple data facets as prep for hypervisor
    • rhelGraphCard, update towards chartArea props update
    • tests, chartArea, i18n and rhelGraphCard tweak

Notes

  • This is a incremental update while the GUI is converted towards displaying the Hypervisor aspect of the RHSM API properties.

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. No visual changes should be detectable. And no console errors should be present

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. No visual changes should be detectable. And no console errors should be present

Example

...

Updates issue/story

Updates #79

…ghts#122)

* chartArea, allow multiple data facets as prep for hypervisor
* rhelGraphCard, update towards chartArea props update
* tests, chartArea, i18n and rhelGraphCard tweak
@cdcabrera cdcabrera force-pushed the issues/79-chartarea branch from 1c925a9 to 10c648f Compare November 5, 2019 16:30
@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #122 into ci will increase coverage by 0.28%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #122      +/-   ##
==========================================
+ Coverage   91.28%   91.56%   +0.28%     
==========================================
  Files          27       27              
  Lines         562      569       +7     
  Branches      148      148              
==========================================
+ Hits          513      521       +8     
+ Misses         39       38       -1     
  Partials       10       10
Impacted Files Coverage Δ
src/components/rhelGraphCard/rhelGraphCard.js 67.74% <ø> (ø) ⬆️
src/components/chartArea/chartArea.js 96.26% <96%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479f05d...10c648f. Read the comment docs.

@cdcabrera cdcabrera merged commit 2fbc4e0 into RedHatInsights:ci Nov 5, 2019
cdcabrera added a commit that referenced this pull request Nov 15, 2019
* chartArea, allow multiple data facets as prep for hypervisor
* rhelGraphCard, update towards chartArea props update
* tests, chartArea, i18n and rhelGraphCard tweak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants