Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): npm updates #1256

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jan 22, 2024

What's included

  • fix(build): npm updates

Notes

  • skipping redux updates with this bulk update. redux and reselect altered how they're consumed
  • there appears to be yet another Victory Charts issue with the latest move over to the "new" consoledot build. We're unclear if it's local development only. The interface, randomly, will throw a max depth exceed warning around a PF encapsulated "VictoryTransition" ... we're hoping this set of package updates help resolve the issue, if not we'll have to investigate it further. The warning does not visually appear to hinder the interface render

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm start
  3. confirm product views still function as intended

Proxy run check

  1. update the NPM packages with $ npm install
  2. make sure Docker is running, plus on network, then
  3. $ npm run start:proxy
  4. confirm product views still function as intended

Check the build

  1. update the NPM packages with $ npm install
  2. $ npm run build
  3. confirm tests come back clean

Example

...

Updates issue/story

ongoing

@codecov-commenter
Copy link

Codecov Report

Merging #1256 (f8827de) into main (e3e4377) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1256   +/-   ##
=======================================
  Coverage   91.90%   91.90%           
=======================================
  Files         122      122           
  Lines        4285     4285           
  Branches     1801     1801           
=======================================
  Hits         3938     3938           
  Misses        327      327           
  Partials       20       20           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3e4377...f8827de. Read the comment docs.

@cdcabrera cdcabrera force-pushed the 20240122-npm-updates branch from f8827de to 15308e7 Compare January 23, 2024 15:45
@cdcabrera cdcabrera merged commit 6e4a962 into RedHatInsights:main Jan 24, 2024
5 of 7 checks passed
cdcabrera added a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202404 project phase build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants