fix(productView): key causes refresh

[cdcabrera]

What's included

• fix(productView): key causes refresh
• refactor(productView): simplify, unnecessary hook
  • this commit can be found here, https://github.com/cdcabrera/curiosity-frontend/tree/20240130-productview-idealsolution

Notes

• simplifies the product view component by removing the no longer necessary useCallback
  • this was done because of routing overlap between swatch and subscriptions inventory
• align to authentication component, consistency
• this started as a fix for the key being used on the provider... we realized unnecessary view refreshes were happening because the key aligned to productID instead of productGroup... updating to productGroup removed the refresh issue (and removing also works)... then we realized the hook itself might not be necessary...
  • UPDATE, the original useCallback is still necessary after testing... the original routing configs are still being applied in production... the ideal fix is here once consoledot corrects the routing... https://github.com/cdcabrera/curiosity-frontend/tree/20240130-productview-idealsolution

How to test the lesser change

Coverage and basic unit test check

1. update the NPM packages with $ npm install
2. $ npm test
3. confirm tests come back clean

Check the build

1. update the NPM packages with $ npm install
2. $ npm run build
3. confirm tests come back clean

How to test the intended change

Coverage and basic unit test check

1. update the NPM packages with $ npm install
2. $ npm test
3. confirm tests come back clean

Local run check

1. update the NPM packages with $ npm install
2. $ npm start
3. confirm the productView loads successfully and product variants can be navigated as intended

Proxy run check (FAILED, reverting to lesser update fix instead, intended change is linked above)

1. update the NPM packages with $ npm install
2. make sure Docker is running, plus on network, then
3. $ npm run start:proxy
4. confirm the productView loads successfully and product variants can be navigated as intended
5. CONFIRM that navigating between other Subscription applications, specifically Inventory, does not cause undue page refreshes due to routing overlap... this is an issue we faced in the past due to the ORIGINAL ROUTING (now that we're under usage the issue may no longer exist... but if someone forgot to remove the old routing configs...)

Check the build

1. update the NPM packages with $ npm install
2. $ npm run build
3. confirm tests come back clean

Example

...

Updates issue/story

ongoing

[codecov-commenter]

Codecov Report

Merging #1264 (5545313) into main (7c8f100) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1264   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         113      113           
  Lines        4257     4257           
  Branches     1802     1802           
=======================================
  Hits         3910     3910           
  Misses        327      327           
  Partials       20       20           

Files	Coverage Δ
src/components/productView/productView.js	100.00% <ø> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c8f100...5545313. Read the comment docs.

[cdcabrera]

As of 20240130 holding due to environment testing issues