Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config) sw-2030 openshift payg inventory links #1280

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(config) sw-2030 openshift payg inventory links

Notes

  • updates inventory links for (any additional products can be updated iteratively)
    • OpenShift Metrics
    • Dedicated Metrics

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm start
  3. confirm inventory instances links for authorized users now navigate towards openshift/details/[id] for the following product ids/variants
    • OpenShift Metrics
    • Dedicated Metrics

Proxy run check

  1. update the NPM packages with $ npm install
  2. make sure Docker is running, plus on network, then
  3. $ npm run start:proxy
  4. confirm inventory instances links for authorized users now navigate towards openshift/details/[id] for the following product ids/variants
    • OpenShift Metrics
    • Dedicated Metrics

Example

...

Updates issue/story

sw-2030

@cdcabrera cdcabrera added the 202404 project phase label Feb 21, 2024
@codecov-commenter
Copy link

Codecov Report

Merging #1280 (6511c25) into main (22f73a5) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1280   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files         114      114           
  Lines        4464     4466    +2     
  Branches     1885     1885           
=======================================
+ Hits         4108     4110    +2     
  Misses        336      336           
  Partials       20       20           
Files Coverage Δ
src/config/product.openshiftDedicated.js 84.48% <66.66%> (+0.27%) ⬆️
src/config/product.openshiftMetrics.js 84.90% <66.66%> (+0.29%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22f73a5...6511c25. Read the comment docs.

@cdcabrera cdcabrera merged commit 0bcc94d into RedHatInsights:main Feb 21, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202404 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants