Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): sw-2357 replace public cloud display copy #1306

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(config): sw-2357 replace public cloud display copy

Notes

  • minor display copy adjustment to align with sorting on "category" for instance inventory displays
    • Affects product configs
      • RHEL
      • Satellite

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm start
  3. Navigate to both the RHEL and Satellite views
    • confirm the instance inventory display column for type has cells that display the cloud provider field only

Proxy run check

  1. update the NPM packages with $ npm install
  2. make sure you're on network, then
  3. $ npm run start:proxy
  4. Navigate to both the RHEL and Satellite views
    • confirm the instance inventory display column for type has cells that display the cloud provider field only

Example

Screenshot 2024-04-02 at 3 28 40 PM

Updates issue/story

sw-2357

@cdcabrera cdcabrera added bug Something isn't working 202304 project phase labels Apr 2, 2024
@cdcabrera cdcabrera marked this pull request as ready for review April 2, 2024 19:29
@codecov-commenter
Copy link

Codecov Report

Merging #1306 (d0704b8) into main (be7315d) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
+ Coverage   91.88%   91.92%   +0.03%     
==========================================
  Files         114      114              
  Lines        4460     4456       -4     
  Branches     1885     1881       -4     
==========================================
- Hits         4098     4096       -2     
+ Misses        340      338       -2     
  Partials       22       22              
Files Coverage Δ
src/services/rhsm/rhsmServices.js 100.00% <ø> (ø)
src/config/product.rhel.js 78.72% <66.66%> (+1.17%) ⬆️
src/config/product.satellite.js 82.85% <66.66%> (+1.77%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be7315d...d0704b8. Read the comment docs.

@cdcabrera cdcabrera merged commit 5ccb6cb into RedHatInsights:main Apr 9, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202304 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants