Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): sw-2402 activate rhel for x86 payg addon #1335

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jun 11, 2024

What's included

  • feat(config): sw-2402 activate rhel for x86 payg addon

Notes

  • activates the RHEL for x86 payg addon as a variant of RHEL ELS x86 PAYG identifier, see screenshot for variant layout
  • adjusts the copy for the original RHEL for x86 payg implementation to be more reflective of what it is
    • this copy is subject to confirmation by documentation

How to test

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm start
  3. navigate to the rhel view
    • Confirm the original RHEL x86 ELS PAYG has had it's copy updated in the variant drop down list AND still fires the original product identifier
    • Confirm the new RHEL x86 ELS PAYG ADDON now HAS the original label used by RHEL x86 ELS PAYG but instead fires the new product identifier

Example

Note: numeric data may, or may not be, accurate during local development

Updated

Screenshot 2024-06-14 at 10 08 07 AM
Screenshot 2024-06-14 at 10 07 54 AM

Screenshot 2024-06-11 at 7 36 34 PM
Screenshot 2024-06-13 at 12-49-37 Standalone Curiosity

Previous

Screenshot 2024-06-11 at 7 08 32 PM

Updates issue/story

sw-2402

@cdcabrera cdcabrera added the 202408 project phase label Jun 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (fb53032) to head (a042f2b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1335   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         113      113           
  Lines        4398     4399    +1     
  Branches     1857     1857           
=======================================
+ Hits         4046     4047    +1     
  Misses        332      332           
  Partials       20       20           
Files Coverage Δ
src/config/product.rhelElsPayg.js 77.35% <100.00%> (ø)
src/services/rhsm/rhsmConstants.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb53032...a042f2b. Read the comment docs.

@jlprevatt
Copy link
Collaborator

As I mentioned in our Slack DM 06/13/2024, I don't think that dropping the 3 characters from the product name (plus adding one back) from "Third" to "3rd" is gaining you anything significant, the name is already long. And it results in a mismatch in the product name from other places (in the HCC or other) that the customer might see it, especially if the name is read directly from the SKU metadata in any of the places it might appear. So I vote for "Third."

@cdcabrera cdcabrera marked this pull request as ready for review June 14, 2024 13:56
@cdcabrera cdcabrera merged commit aa474f0 into RedHatInsights:main Jun 14, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202408 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants